Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.9.2 Release #124

Merged
merged 57 commits into from
May 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
2273151
first sketch
MattReimer Mar 26, 2024
007bce4
login working
MattReimer Mar 27, 2024
cbdecf1
more state handling
MattReimer Mar 27, 2024
e714365
adding more graphql stuff
MattReimer Mar 28, 2024
44340b2
project retrieving correctly
MattReimer Mar 28, 2024
eab4920
better debugging
MattReimer Apr 10, 2024
1c352a4
form is feature complete
MattReimer Apr 10, 2024
ccd9638
validation working finally
MattReimer Apr 10, 2024
427f1a8
Ready for uploads
MattReimer Apr 12, 2024
c764a51
multipart still not working and cancel not implemented
MattReimer Apr 13, 2024
e5a6d42
code comments and docs
MattReimer Apr 15, 2024
0e0ca90
partial file streaming
MattReimer Apr 16, 2024
b145d3f
reworking
MattReimer Apr 16, 2024
c9b78b7
first time uploading all files correctly
MattReimer Apr 16, 2024
c311efc
upload progress is working
MattReimer Apr 17, 2024
524bc6a
reworking the files digest and adding noDelete
MattReimer Apr 17, 2024
bcf616b
error handling improvements
MattReimer Apr 18, 2024
f0a53bf
more logging improvements
MattReimer Apr 18, 2024
3ff08f3
more logging tweaks
MattReimer Apr 18, 2024
bb21748
cancellation bug fixed
MattReimer Apr 18, 2024
56fc79b
minor tweaks to workflow
MattReimer Apr 18, 2024
bb2af4f
removing state of dataexchange
MattReimer Apr 18, 2024
6f5176e
Updated project upload fixes
MattReimer Apr 18, 2024
c0e0f80
better progress reporting
MattReimer Apr 19, 2024
a43d62d
precalc whether an upload is necessary
MattReimer Apr 19, 2024
44931bb
extra log line is important
MattReimer Apr 19, 2024
375f85e
don't reset digest on start
MattReimer Apr 19, 2024
040e20c
fix for badly disabled new project uploads
MattReimer Apr 19, 2024
e22b0c4
Philips ui changes
philipbaileynar Apr 19, 2024
0a78afd
adding the wheel support and instruction
MattReimer Apr 22, 2024
0b18a3f
reload project after upload dialog close
MattReimer Apr 22, 2024
d6106de
adding dialog for clobbering upstream projects
MattReimer Apr 22, 2024
10bbc6a
bumping version to 0.9.2
MattReimer Apr 22, 2024
c81258a
project update setting is now done server-side
MattReimer Apr 22, 2024
1ec5a77
fixing some windows debug problems
MattReimer Apr 24, 2024
e081e5a
windows slash issues
MattReimer Apr 24, 2024
2dc3caa
fix for the authentication timeout
MattReimer Apr 24, 2024
0b06e02
fix to OSX regression
MattReimer Apr 24, 2024
8ba4018
Adding deploy wheel check so we don't accidentally publish without them
MattReimer Apr 25, 2024
6344708
hopefully better logins when projects don't load
MattReimer Apr 25, 2024
660d02d
fixing close all #107
MattReimer Apr 25, 2024
44f1f0c
UI files are already out of date. Deleting them
MattReimer Apr 25, 2024
8d4fe70
removing qrave references #99
MattReimer Apr 25, 2024
0e9aba2
better exception handling for https server #119
MattReimer Apr 25, 2024
757f9fe
BL loading error handling should be better now
MattReimer Apr 25, 2024
42a01d9
Cleaning up https server incorrectly. FIXED
MattReimer Apr 25, 2024
694172e
Fixing deleted project bug #116
MattReimer Apr 25, 2024
faead7d
fixing windows linesep problem to get single-spaced logs again
MattReimer Apr 25, 2024
d60182b
better logging on file changes
MattReimer Apr 25, 2024
5e49688
fixing md5 hashes #120
MattReimer Apr 25, 2024
71f8968
cleaning up logs and debugging variables
MattReimer Apr 26, 2024
1db70d3
checklist and dependency script docs
MattReimer Apr 26, 2024
bd7d43e
version 0.9.2 changelog
KellyMWhitehead Apr 26, 2024
d3fb7b7
making sure graphql files get into the deploy script #117
MattReimer May 1, 2024
a6180f4
Fixing error that is preventing Messagebar printing #123
MattReimer May 8, 2024
f97e091
additional changelog
KellyMWhitehead May 8, 2024
96bbe65
disabling checking for wheel file in deploy due to false negative
KellyMWhitehead May 8, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,23 +6,23 @@
"configurations": [
{
"name": "QGIS Debug",
"type": "python",
"type": "debugpy",
"request": "attach",
"connect": {
"host": "localhost",
"port": 5678
},
"pathMappings": [
{
"localRoot": "${workspaceFolder}",
"remoteRoot": "${workspaceFolder}",
}
],
// "pathMappings": [
// {
// "localRoot": "${workspaceFolder}",
// "remoteRoot": "${workspaceFolder}",
// }
// ],
"justMyCode": true
},
{
"name": "Python: Current File",
"type": "python",
"type": "debugpy",
"request": "launch",
"program": "${file}",
"cwd": "${workspaceFolder}",
Expand Down
14 changes: 14 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,18 @@

## 0.9.2 ***(April 26, 2024)***

### Added
- Project Data Exchange Uploader

### Fixed
- Close All Projects Throws Error #107
- Better Business logic handling
- Message bar was not showing up #123
- GraphQL files not being included in the deploy #117

### Changed
- Removed additional "QRAVE" references

## 0.9.1 ***(March 27, 2024)***

### Fixed
Expand Down
15 changes: 8 additions & 7 deletions CHECKLIST.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,11 @@ NEVER WORK DIRECTLY ON THE MASTER BRANCH
1. Commit and push everything to git
2. increment the version number in `__version__.py`
3. Do a compile of all the UI and resources and commit that `pb_tool compile`
4. Run the `deploy.py` script once and test the local version of the plugin
5. Do a code review and a pull request to get this onto the master branch
6. Tag the commit in git with the version number
7. Run `deploy.py` again. This will produce the zip file to upload
8. Test again
9. Go to https://plugins.qgis.org/plugins/riverscapes_viewer/ and log in. You should be able to manage and add a new version from there.
10. Go make a release on github. This might be redundant but.... TBA
4. Make sure all dependencies are in place by running `sh ./scripts/installDeps.sh`
5. Run the `deploy.py` script once and test the local version of the plugin
6. Do a code review and a pull request to get this onto the master branch
7. Tag the commit in git with the version number
8. Run `deploy.py` again. This will produce the zip file to upload
9. Test again
10. Go to https://plugins.qgis.org/plugins/riverscapes_viewer/ and log in. You should be able to manage and add a new version from there.
11. Go make a release on github. This might be redundant but.... TBA
1 change: 1 addition & 0 deletions Images/mActionEditCopy.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
43 changes: 43 additions & 0 deletions Images/upload_project.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
60 changes: 59 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,11 @@ The Riverscapes Viewer (formerly QRAVE) is a [QGIS](http://www.qgis.org/en/site/

The Riverscapes Viewer Plugin software was developed by North Arrow Research Ltd., with funding form the [Bonneville Power Administration](https://www.bpa.gov/) (BPA) BPA Fish and Wildlife Program Project [#2011-006](http://www.cbfish.org/Project.mvc/Display/2011-006-00). Contributions were also made by [South Fork Research](http://www.southforkresearch.org/) and members of the [Fluvial Habitats Center](http://etal.joewheaton.org/a/joewheaton.org/et-al/) at Utah State University.

## Developing on windows
## Developing on Windows OR OSX

Make sure the `RS_DEBUG=true` is set in QGIS Environment

## Developing on windows

1. Make a batch file on your desktop to launch VSCode with the QGIS development paths and environment

Expand Down Expand Up @@ -96,6 +99,19 @@ Launching the Qt designer:
$QGIS_PATH/Contents/MacOS/bin/designer
```

## `rsxml` dependency

This plugin uses the `rsxml` library to parse and manipulate Riverscapes XML files. This library is available on PyPi butso you need to install it manually as a wheel so that the plugin can use it. You can install it using the following command:

```bash
sh ./scripts/install_deps.sh
```

THis is just running the following command:

```bash
$QGIS_PATH_PYTHON_PATH/pip3 wheel rsxml==2.0.1 -w ./wheels --no-deps
```

## Development resources

Expand All @@ -104,13 +120,49 @@ $QGIS_PATH/Contents/MacOS/bin/designer
* [Qt for Python](https://doc.qt.io/qtforpython-5/) - Qt is a C++ library so you need to specify the Python docs. This is where you find help with things like QtGui and QtWidgets


## Buildsing the UI files

```
pyuic5 -x input.ui -o output.py
```

## License

Licensed under the [GNU General Public License Version 3](https://github.com/Riverscapes/RiverscapesToolbar/blob/master/LICENSE).

## QT Designer

### Installing `pb_tool`

First make sure that pb_tool is installed (note that you may need to adjust your QGIS paths in the commands below )

```
/Applications/QGIS-LTR.app/Contents/MacOS/bin/pip3 install pb_tool
```

### Running `pb_tool` compile

You just need to run `pb_tool compile` from the installed QGIS python environment. Make sure you're in the repo root for QRavePlugin when you do that

pb_tool compile will do 2 things:

1. It will run pyrcc5 on the `src/resources.qrc` file and compile it to a python file in the `src` directory
2. It will run pyuic5 on the `src/ui/*.ui` files and compile them to python files in the `src/ui` directory

```bash
> /Applications/QGIS-LTR.app/Contents/MacOS/bin/pb_tool compile
Skipping ./src/ui/dock_widget.ui (unchanged)
Skipping ./src/ui/meta_widget.ui (unchanged)
Skipping ./src/ui/meta_widget.ui (unchanged)
Skipping ./src/ui/about_dialog.ui (unchanged)
Skipping ./src/ui/options_dialog.ui (unchanged)
Compiling ./src/ui/project_upload_dialog.ui to ./src/ui/project_upload_dialog.py
Compiled 1 UI files
Compiling ./src/resources.qrc to ./src/resources.py
Compiled 1 resource files
```


On MacOS

`/Applications/QGIS.app/Contents/MacOS/bin/designer`
Expand All @@ -124,3 +176,9 @@ On MacOS
1. Drop a breakpoint.
1. Cause the breakpoint to fire. VSCode should pause at the breakpoint.

```
https://github.com/planetfederal/qgis-connect-plugin/blob/885773aa0bed618f85bd15d4c67ccbbcf9bee64c/boundlessconnect/gui/connectdockwidget.py#L430
```



19 changes: 15 additions & 4 deletions Workspaces/OSXDev.code-workspace
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,23 @@
// "editor.background": "#1c2c2a"
},
"terminal.integrated.env.osx": {
"PYTHONPATH": "${env:QGIS_PATH}/Contents/Resources/python:${env:QGIS_PATH}/Contents/Resources/python/site-packages:${env:QGIS_PATH}/Contents/Resources/python/site-packages/PyQt5",
"PYTHONPATH": "${env:QGIS_PATH}/Contents/Resources/python:${env:QGIS_PATH}/Contents/Resources/python/site-packages:${env:QGIS_PATH}/Contents/Resources/python/site-packages/PyQt5:${workspaceFolder}/wheels",
"PATH": "${env:PATH}:${env:QGIS_PATH}/Contents/MacOS/bin"
},
// NOTE: For this to work you need an env file with "QGIS_PATH=/Applications/QGIS-LTR.app/Contents" or whatever your path is
"python.pythonPath": "${env:QGIS_PATH}/Contents/MacOS/bin/python3.8",
},
"terminal.integrated.defaultProfile.linux": "zsh",
"[python]": {
"editor.tabSize": 4,
"editor.formatOnSave": true,
},
"autopep8.args": [
"--max-line-length=240",
],
"pylint.args": [
"--extension-pkg-whitelist=pygeoprocessing",
"--disable=C0301,C0114,C0103,W0719,W0718",
"--max-line-length=240"
],
},
"launch": {
"configurations": [],
"compounds": []
Expand Down
2 changes: 1 addition & 1 deletion __version__.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "0.9.1"
__version__ = "0.9.2"
11 changes: 10 additions & 1 deletion config.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,15 @@
"webUrl": "https://viewer.riverscapes.net",
"issueUrl": "https://github.com/Riverscapes/QRAVEPlugin/issues",
"changelogUrl": "https://github.com/Riverscapes/QRAVEPlugin/releases",
"resourcesUrl": "https://xml.riverscapes.net/"
"resourcesUrl": "https://xml.riverscapes.net/",
"DE_API_URL": "https://api.data.riverscapes.net",
"DE_API_AUTH": {
"audience": "https://api.riverscapes.net",
"domain": "auth.riverscapes.net",
"clientId": "pH1ADlGVi69rMozJS1cixkuL5DMVLhKC",
"scope": "openid",
"success_url": "https://data.riverscapes.net/login_success",
"port": 4721
}
}
}
Loading