Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capacity model applied to canals with DA above threshold #531

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

jtgilbert
Copy link
Contributor

I noticed that some canals are attributed with the DA from the river they're diverted off of, so the capacity model wasn't being applied to canals coming off of the rivers with DA larger than the max DA for the HUC. This, in turn, affects the potential conflict model (i.e., shows no conflict where there actually could be in canals). I made the change and tested it successfully here:
https://data.riverscapes.xyz/#/BEAR/03df162f-38c2-44fc-af89-6a06f376a03f

@jtgilbert jtgilbert added enhancement New feature or request pkg:BRAT BRAT Python Package labels Dec 23, 2021
@philipbaileynar
Copy link
Contributor

We are aware that side channels (not just canals) sometimes have the DA of the adjacent mainstem. In the case of side channels, this can cause the side channel to get assigned "blow out" and no dam capacity when in fact, the side channel capacity should be much lower than the mainstem and is ideal beaver habitat.

@KellyMWhitehead has investigated the NHD attributes and discovered useful attributes pertaining that help distinguish side channels from mainstems. The same logic might apply to canals.

I'm wondering if we solve the side channel issue it might also solve this canal issue at the same time and might make the FIS changes proposed here unnecessary?

(Might be easiest to discuss rather than type...)

@jtgilbert
Copy link
Contributor Author

Yeah, if there's a way to solve both this issues in the same way that would probably be ideal.

@philipbaileynar
Copy link
Contributor

@jtgilbert is this required/desired?

@jtgilbert
Copy link
Contributor Author

@philipbaileynar I would say yes, I think it's important for accurately representing conflict potential.

Copy link
Contributor

@philipbaileynar philipbaileynar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving following discussion with @jtgilbert

@MattReimer MattReimer merged commit 1c83024 into master Feb 3, 2022
@MattReimer MattReimer deleted the canal-capacity branch February 3, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pkg:BRAT BRAT Python Package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants