Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation for zh-TW #8

Closed
wants to merge 8 commits into from
Closed

Conversation

et169tkm
Copy link

Hi,

Thanks for your great work, your emulator is fabulous!!! (And saved me 18 gold medals :P )

I've forked your repository just to add translation, I have no intention of making a duplicate.
I've added the zh-TW translation in a few places.
Would you review my commits? And if you don't like my approach, please let me know and I'm happy to follow the approach you like.

Many Thanks,
Eric

@WindWT
Copy link
Contributor

WindWT commented Apr 4, 2018

What you need is dump & convert files from TW/WeGame server(/data/*.json), not translate data from CN/XinDong server.
Some of those data extract tools are not open-sourced(but it's pretty easy to reinvent the wheel), others are other people's open-source project(since it's a unity game, you know how to choose tools). If you just want an rune simulator for TW/WeGame server, make your own extract tool, extract data, and replace /data might be an better idea.
Supporting mutiple servers' data is another approach, but because of I have new waifu I'm losing interest on this game and some other reasons(mostly health issues), I'm lazy adding functions for this project. If you can't wait, you can just publish your translated version without my approvement.

TLDR:

  1. NO, I won't merge this.
  2. YES, you can do anything you like with this code.
  3. I may or may not add function for switching different server datas.

@WindWT WindWT closed this Apr 4, 2018
@WindWT
Copy link
Contributor

WindWT commented Apr 4, 2018

I didn't check mails for a long time, sorry to keep you waiting.

@et169tkm
Copy link
Author

et169tkm commented Apr 4, 2018 via email

@WindWT WindWT mentioned this pull request May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants