feat(#651): Java module system support, upgrade to Java 11 #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a `module-info.java` file describing the public interface of the RoaringMap. Since all classes are in a single package, it represents practically all content. Previous compatibility with Java 8 and the `shims` library, which contained a multi-release build supporting both Java 11 and older versions of the Java runtime, could not be maintained. Currently only Java 11 is supported by RoaringBitmap. BREAKING CHANGE: Minimal Java version updated to Java 11.
Corrected duplicated imports. Added `art` package to opened packages since its used in RoaringBitmap64 API (method parameters).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a
module-info.javafile describing the public interface of the RoaringMap. Since all classes are in a single package, it represents practically all content.Previous compatibility with Java 8 and the
shimslibrary, which contained a multi-release build supporting both Java 11 and older versions of the Java runtime, could not be maintained. Currently only Java 11 is supported by RoaringBitmap.BREAKING CHANGE: Minimal Java version updated to Java 11.
SUMMARY
Automated Checks
./gradlew testand made sure that my PR does not break any unit test../gradlew checkstyleMainor the equivalent and corrected the formatting warnings reported.