Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

user fullname and email is now editable(fixes: #215) #218

Merged
merged 7 commits into from Jan 8, 2019
Merged

user fullname and email is now editable(fixes: #215) #218

merged 7 commits into from Jan 8, 2019

Conversation

Hjortsberg
Copy link
Member

@Hjortsberg Hjortsberg commented Jan 8, 2019 •
edited by wstrm

savior

other fixes include:

  • 100% wide profile picture
  • removed password from API docs on user update
  • updated database ump and illustration

@Hjortsberg
user fullname and email is now editable(fixes: #215)
cc08331 
other fixes include:
* 100% wide profile picture
* removed password from API docs on user update
* updated database ump and illustration
@Hjortsberg Hjortsberg added DB Database related Docs Documentation related Backend Das hintere Ende Frontend Das vordere Ende labels Jan 8, 2019
@Hjortsberg Hjortsberg self-assigned this Jan 8, 2019
@Hjortsberg Hjortsberg added this to In progress in Roaster via automation Jan 8, 2019
@Hjortsberg Hjortsberg requested a review from wstrm January 8, 2019 14:14
@coveralls
Copy link

coveralls commented Jan 8, 2019 •
edited

Pull Request Test Coverage Report for Build 757

  • 0 of 54 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 7.547%
Changes Missing Coverage Covered Lines Changed/Added Lines %
model/user.go 0 20 0.0%
router/route/user.go 0 34 0.0%
Totals Coverage Status
Change from base Build 749: -0.2%
Covered Lines: 120
Relevant Lines: 1590
💛 - Coveralls

@Hjortsberg
Copy link
Member Author

review plz @willeponken review plz @willeponken review plz @willeponken review plz @willeponken review plz @willeponken review plz @willeponken review plz @willeponken review plz @willeponken review plz @willeponken review plz @willeponken review plz @willeponken review plz @willeponken review plz @willeponken review plz @willeponken review plz @willeponken review plz @willeponken review plz @willeponken review plz @willeponken review plz @willeponken review plz @willeponken review plz @willeponken review plz @willeponken

Roaster automation moved this from In progress to Reviewer approved Jan 8, 2019
wstrm
wstrm approved these changes Jan 8, 2019
View reviewed changes
Copy link
Member

@wstrm wstrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MERGE 🔜 RELEASE PARTY

@Hjortsberg Hjortsberg merged commit 1a1a96f into master Jan 8, 2019
Roaster automation moved this from Reviewer approved to Done Jan 8, 2019
@wstrm wstrm mentioned this pull request Jan 8, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wstrm wstrm wstrm approved these changes

Assignees

@Hjortsberg Hjortsberg

Labels
Backend Das hintere Ende DB Database related Docs Documentation related Frontend Das vordere Ende
Projects
Roaster
  
Done
Milestone
9. Final presentation including final...
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Hjortsberg @coveralls @wstrm