Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No error shown when leaving Full name empty, but submit button left disabled #210

Open
optmzr opened this issue Jan 8, 2019 · 2 comments
Open

Comments

@optmzr
Copy link
Member

@optmzr optmzr commented Jan 8, 2019

According to the API spec. the fullname field is not required, but this isn't throughly tested (I believe most stuff on the frontend will just display an empty full name, should maybe display the username at some places, and not anything in the search results).

So the quickfix in the mean time would be to just require the full name in the frontend, and display an error if empty, and then in the future fix the views.

I believe this one can be on hold.

@optmzr

This comment has been minimized.

Copy link
Member Author

@optmzr optmzr commented Jan 8, 2019

@Hjortsberg, I'll mark this as partially fixed.

@optmzr

This comment has been minimized.

Copy link
Member Author

@optmzr optmzr commented Jan 8, 2019

Partially fixed in #218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.