-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discover return types for functions and methods #104
Conversation
/* @var $returnTag \phpDocumentor\Reflection\DocBlock\Tag\ReturnTag */ | ||
return (new ResolveTypes())->__invoke($returnTag->getTypes(), $context); | ||
} | ||
return []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be mixed
by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, I don't think we should make any assumptions about return types. If they're there, we return them, if not, we don't. Plain and simple that way - if applications using Better Refletion want to make that assumption, they can do so simply.
Discover return types for functions and methods
@asgrim you trolling with assignees ? :P |
@nclundsten sorry - clicked the wrong name ^_^ |
no prob, was just surprised when i started getting notifications |
See #10