Discover return types for functions and methods #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /* @var $returnTag \phpDocumentor\Reflection\DocBlock\Tag\ReturnTag */ | ||
| return (new ResolveTypes())->__invoke($returnTag->getTypes(), $context); | ||
| } | ||
| return []; |
There was a problem hiding this comment.
Should it be mixed by default?
There was a problem hiding this comment.
I don't think so, I don't think we should make any assumptions about return types. If they're there, we return them, if not, we don't. Plain and simple that way - if applications using Better Refletion want to make that assumption, they can do so simply.
asgrim
changed the title
asgrim
changed the title
Ocramius
added a commit
that referenced
this pull request
Aug 20, 2015
Discover return types for functions and methods
|
@asgrim you trolling with assignees ? :P |
|
@nclundsten sorry - clicked the wrong name ^_^ |
|
no prob, was just surprised when i started getting notifications |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #10