Removed ReflectionProperty::getAst() to prevent memory leaks
#1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kukulich
force-pushed
the
ast
branch
3 times, most recently
from
e8f112b
to
f4917bc
Compare
Ocramius
requested changes
Sep 22, 2022
Yeah, I think the restriction was in place due to shared mutable internal state: removal of the AST should fix that. |
Ocramius
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another part of #1073
I made
ReflectionPropertycloneable because it was the most easy way. I've found issue #61 but I'm not sure if it's still relevant. Is it not enough that adapters are not cloneable ?Btw there are already some classes that are cloneable, eg.
ReflectionConstantorReflectionEnumCase.