Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for source stubbers #467

Merged
merged 2 commits into from Apr 24, 2019
Merged

Tests for source stubbers #467

merged 2 commits into from Apr 24, 2019

Conversation

kukulich
Copy link
Collaborator

As mentioned in #373

@Ocramius
Copy link
Member

Hmm, fails for:

1) Roave\BetterReflectionTest\SourceLocator\SourceStubber\PhpStormStubsSourceStubberTest::testInternalClasses with data set #4 ('ParseError')
Roave\BetterReflection\Reflector\Exception\IdentifierNotFound: Roave\BetterReflection\Reflection\ReflectionClass "CompileError" could not be found in the located source
/home/travis/build/Roave/BetterReflection/src/Reflector/Exception/IdentifierNotFound.php:30
/home/travis/build/Roave/BetterReflection/src/Reflector/ClassReflector.php:39
/home/travis/build/Roave/BetterReflection/src/Reflection/ReflectionClass.php:792
/home/travis/build/Roave/BetterReflection/test/unit/SourceLocator/SourceStubber/PhpStormStubsSourceStubberTest.php:124
/home/travis/build/Roave/BetterReflection/test/unit/SourceLocator/SourceStubber/PhpStormStubsSourceStubberTest.php:147
/home/travis/build/Roave/BetterReflection/test/unit/SourceLocator/SourceStubber/PhpStormStubsSourceStubberTest.php:118

@Ocramius Ocramius added this to the 3.5.0 milestone Apr 24, 2019
@kukulich
Copy link
Collaborator Author

Will fix. I tested only PHP 7.3 on localhost

@kukulich
Copy link
Collaborator Author

@Ocramius Travis is ok. I don't know if Scrutinizer error is valid.

Ocramius
Ocramius approved these changes Apr 24, 2019
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scrutinizer-ci failures are not super-important, so this is 👍

@Ocramius Ocramius merged commit 173f42c into Roave:master Apr 24, 2019
@kukulich kukulich deleted the tests branch April 24, 2019 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@kukulich kukulich

Labels
enhancement
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kukulich @Ocramius