Source stubber based on `jetbrains/phpstorm-stubs` by kukulich · Pull Request #373 · Roave/BetterReflection

kukulich · 2017-09-22T15:01:32Z

Proof of concept to have something to discuss.

Ocramius

Partial review for now - will get back to this :-)

kukulich · 2017-09-22T16:41:28Z

@Ocramius just for your info: a lot of tests are missing here currently, I will write them later when I know you are ok with the interface etc :)

theofidry · 2018-04-25T13:24:41Z

The repo is now tagged https://github.com/JetBrains/phpstorm-stubs/releases/tag/2018.1.2 :)

asgrim · 2018-04-25T14:34:20Z

that's one hell of a high major version 😀

asgrim

The title says WIP, but this seems reasonable addition now - is there anything stopping a rebase to fix conflicts and getting this merged @kukulich ? Thanks

kukulich · 2019-01-25T16:51:47Z

@asgrim If there are no objections about the way how I've implemented it I can rebase it, add tests and prepare for final review :)

asgrim · 2019-01-26T11:02:59Z

@kukulich no objections here; seems fine to me 👍

jcsilkey · 2019-02-25T23:45:30Z

Hello!

I just started working on a similar effort (https://github.com/jcsilkey/BetterReflection/tree/stubber) for my own personal usage before I looked and saw this PR existed. I wasn't aiming to replace the internal stubs with the JetBrains stubs but rather a different set and therefore needed to refactor the SourceLocator to be able to pass in a custom Stubber instance. Anyhow, I see that this PR hasn't been updated in a quite a while and I'd be willing to consolidate the two and update it if there are no objections (particularly from @kukulich since this is his work).

Thanks!

asgrim · 2019-02-26T08:10:04Z

@jcsilkey interesting: what is the use case you're trying to solve? BR can already load classes from files (e.g. SingleFileSourceLocator for single files, DirectoriesSourceLocator for anything in a folder), so I'm wondering if they can't just be used. I'm assuming you have a directory of PHP files for the stubs, otherwise, in what form would you be supplying the stubs? Is it just because the JB stubs aren't sufficient?

General side note for @Ocramius / @kukulich - I wonder if it makes sense to replace the mechanism of PhpInternalSourceLocator with just a wrapper around DirectoriesSourceLocator that points to the JB stubs...?

Ocramius · 2019-02-26T08:53:50Z

I'd add a new source locator for now: we don't yet know the quality of the phpstorm one, so we'll have to leave the old one in place for a while

…

On Tue, 26 Feb 2019, 09:10 James Titcumb, ***@***.***> wrote: @jcsilkey <https://github.com/jcsilkey> interesting: what is the use case you're trying to solve? BR can already load classes from files (e.g. SingleFileSourceLocator for single files, DirectoriesSourceLocator for anything in a folder), so I'm wondering if they can't just be used. I'm assuming you have a directory of PHP files for the stubs, otherwise, in what form would you be supplying the stubs? Is it just because the JB stubs aren't sufficient? General side note for @Ocramius <https://github.com/Ocramius> / @kukulich <https://github.com/kukulich> - I wonder if it makes sense to replace the mechanism of PhpInternalSourceLocator with just a wrapper around DirectoriesSourceLocator that points to the JB stubs...? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#373 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJakAawq0AfyQdFLP3O6Wc8V2AhmoyHks5vROvcgaJpZM4Pg1QH> .

kukulich · 2019-02-26T09:44:08Z

I plan to rebase this PR in March.

sebastianbergmann · 2019-03-27T07:37:04Z

@kukulich Can you foresee when you'll be able to rebase this PR? Thanks! I am asking because of sebastianbergmann/phpunit#3577 (comment).

kukulich · 2019-03-27T10:04:10Z

@sebastianbergmann It’s in progress. Both chilldren were ill in March so less free time than expected :( I hope I will finish it in 14 days

sebastianbergmann · 2019-03-27T10:06:17Z

@kukulich Thanks for the update. Familiy first! Hope your children are no longer ill.

kukulich · 2019-03-29T09:13:08Z

The PR is rebased and build is green (Travis is green, AppVeyor is 💩 )

I have to still write new tests.

Ocramius · 2019-04-16T11:26:35Z

@kukulich btw, sorry for not noticing this patch before!

…StubberTest

Ocramius · 2019-04-20T07:54:13Z

AppVeyor failures are coming from "standard Windows PHP environment weirdness", so they can be ignored.

Ocramius · 2019-04-20T07:54:45Z

Thanks @kukulich!

Ocramius · 2019-04-20T08:02:49Z

-    /**
-     * Determine if a stub exists for specified class name
-     */
-    public function hasStub(string $className) : bool


For future readers: this is indeed a BC break, but since this is an internal component (which is erroneously not marked as @internal), we can ignore it.

kukulich · 2019-04-20T08:42:41Z

@Ocramius You are really fast :) As I mentioned in previous comment, tests are missing. I’ll send PR with them ASAP (next week)

Ocramius · 2019-04-20T08:44:56Z

Urghh, I'll need a coverage threshold plugin to be added to the build to prevent this. I expect to finish up another patch today, so we'll likely also have 3.4.0.

theofidry · 2019-05-05T21:29:39Z

        parent::__construct($astLocator);

-        $this->stubber = new SourceStubber();
+        $this->stubber = $stubber ?? new ReflectionSourceStubber();


shouldn't this include the phpstorm stubber as well?

@theofidry No, because it would be BC break.

kukulich force-pushed the source-stubber branch from 76dcab5 to 5f677bb Compare September 22, 2017 16:01

Ocramius requested changes Sep 22, 2017

View reviewed changes

kukulich force-pushed the source-stubber branch 2 times, most recently from c99097d to 0e54523 Compare September 25, 2017 21:16

kukulich mentioned this pull request May 8, 2018

Updated to nikic/PHP-Parser 4.x #410

Merged

kukulich force-pushed the source-stubber branch 3 times, most recently from 93096e7 to 9149d75 Compare May 23, 2018 06:31

asgrim assigned kukulich Jan 25, 2019

asgrim reviewed Jan 25, 2019

View reviewed changes

Ocramius mentioned this pull request Mar 26, 2019

Scoped PHAR xdebug issue sebastianbergmann/phpunit#3577

Closed

stof reviewed Mar 27, 2019

View reviewed changes

Comment thread composer.json Outdated

stof reviewed Mar 27, 2019

View reviewed changes

Comment thread src/SourceLocator/SourceStubber/PhpStormStubsSourceStubber.php Outdated

kukulich added 3 commits March 29, 2019 07:51

SourceStubber renamed to ReflectionSourceStubber

6cb6de9

Changed namespace of ReflectionSourceStubber

b947e40

Constant for PhpParser builder options

bf3a8fe

kukulich force-pushed the source-stubber branch from 9149d75 to 6b36778 Compare March 29, 2019 08:41

Ocramius requested changes Apr 16, 2019

View reviewed changes

Ocramius added BC break enhancement labels Apr 16, 2019

Ocramius added this to the 4.0.0 milestone Apr 16, 2019

kukulich added 6 commits April 19, 2019 13:45

Added SourceStubber interface

274432f

SourceStubber is injected everywhere

51098b7

Removed stubs

507ca4e

Basic reflection for internal functions

c4d924a

SourceStubber now returns stub code with PHP opening tag

0615617

Move some tests from PhpInternalSourceLocatorTest to ReflectionSource…

a6dc9ce

…StubberTest

kukulich force-pushed the source-stubber branch from 6b36778 to d392fb7 Compare April 19, 2019 11:52

kukulich added 2 commits April 19, 2019 13:55

Added PhpStormStubsSourceStubber

d69380f

Added AggregateSourceStubber

de580a8

kukulich force-pushed the source-stubber branch from d392fb7 to de580a8 Compare April 19, 2019 11:56

Ocramius approved these changes Apr 20, 2019

View reviewed changes

Ocramius changed the title ~~WIP Source stubber based on jetbrains/phpstorm-stubs~~ Source stubber based on jetbrains/phpstorm-stubs Apr 20, 2019

Ocramius merged commit df78b55 into Roave:master Apr 20, 2019

Ocramius modified the milestones: 4.0.0, 3.3.0 Apr 20, 2019

Ocramius reviewed Apr 20, 2019

View reviewed changes

kukulich deleted the source-stubber branch April 21, 2019 07:20

kukulich mentioned this pull request Apr 24, 2019

Tests for source stubbers #467

Merged

theofidry mentioned this pull request May 5, 2019

Use jetbrains/phpstorm-stubs? #261

Closed

theofidry reviewed May 5, 2019

View reviewed changes

Conversation

kukulich commented Sep 22, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ocramius left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kukulich commented Sep 22, 2017

Uh oh!

theofidry commented Apr 25, 2018

Uh oh!

asgrim commented Apr 25, 2018

Uh oh!

asgrim left a comment

Choose a reason for hiding this comment

Uh oh!

kukulich commented Jan 25, 2019

Uh oh!

asgrim commented Jan 26, 2019

Uh oh!

jcsilkey commented Feb 25, 2019

Uh oh!

asgrim commented Feb 26, 2019

Uh oh!

Ocramius commented Feb 26, 2019 via email

Uh oh!

kukulich commented Feb 26, 2019

Uh oh!

sebastianbergmann commented Mar 27, 2019

Uh oh!

kukulich commented Mar 27, 2019

Uh oh!

sebastianbergmann commented Mar 27, 2019

Uh oh!

Uh oh!

Uh oh!

kukulich commented Mar 29, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Ocramius commented Apr 16, 2019

Uh oh!

Ocramius commented Apr 20, 2019

Uh oh!

Ocramius commented Apr 20, 2019

Uh oh!

Ocramius Apr 20, 2019

Choose a reason for hiding this comment

Uh oh!

kukulich commented Apr 20, 2019

Uh oh!

Ocramius commented Apr 20, 2019

Uh oh!

theofidry May 5, 2019

Choose a reason for hiding this comment

Uh oh!

kukulich May 5, 2019

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

kukulich commented Sep 22, 2017 •

edited

Loading