Fix CS #506
Fix CS #506
Conversation
|
Do you really need PHP 7.1 support, considering that it's EOL'd and out of security support? On this end, we'll likely keep compat only with the current minor, since PHP is an elusive target. |
| @@ -205,7 +205,7 @@ private function assertMemoization( | |||
| Reflector $reflector, | |||
| Identifier $identifier | |||
| ) use ( | |||
| & $fetchedSymbolsCount | |||
| &$fetchedSymbolsCount | |||
There was a problem hiding this comment.
This is potentially caused by doctrine/coding-standard:6.0.0 depending on PSR-12 rules that were changed in upstream phpcs. Upgrading to doctrine/coding-standard:7.0.2 should fix these, in theory.
There was a problem hiding this comment.
@kukulich told me that he'll be updating BetterRefleciton to doctrine/coding-standard:7.x so I'll leave it up to him :)
I'm thinking pragmatically. There's nothing in PHP 7.2 that I'd take advantage of. It also breaks my heart when someone When it's cheap for me to support PHP 7.1, there isn't a reason not to. Funny thing - BetterReflection would still fully support PHP 7.1 if it weren't for the constraint in composer.json. The only thing I had to do to make the build pass was to downgrade PHPUnit to 7.5.18 :) Also, thanks to PHAR-only distribution, I now have the advantage of a build step. I could theoretically develop PHPStan for PHP 7.4 only, and transform the sources to also support PHP 7.1 every time before publishing. |
We dropped previous versions because it was not cheap for us to maintain them 🤷♀️ |
|
Yeah, but this does not apply now because of small jumps in 7.2 and 7.3. I also wanted |
Hi, I'm in the process of creating my own PHP 7.1-compatible fork (hope you're fine with that! It will land in PHPStan pretty soon I expect). I stumbled upon this build issue (it fails here on master), so I'm sending a fix :)
Thank you!