Update doctrine/coding-standard from 6.0.0 to 7.0.2 #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
requested changes
Jan 10, 2020
| $sourceLocator = $this | ||
| ->getMockBuilder(StringSourceLocator::class) | ||
| ->disableOriginalConstructor() | ||
| ->setMethods(['locateIdentifier']) | ||
| ->getMock(); | ||
| assert($sourceLocator instanceof StringSourceLocator || $sourceLocator instanceof MockObject); |
There was a problem hiding this comment.
Should be && for these transformations
| $mockReflector = $this->createMock(Reflector::class); | ||
| assert($mockReflector instanceof Reflector || $mockReflector instanceof MockObject); |
There was a problem hiding this comment.
Since newer phpunit versions, we can drop these, since direct $this->createMock() calls (without builder) can be correctly inferred AFAIK
|
Build https://travis-ci.org/Roave/BetterReflection/jobs/635186981 failed due to too old phpunit version: we can bump the minimum supported version safely |
|
🤞 |
LULZ CS is good though, so I would merge this as-is, and bring the new problem with me as a separate issue. |
Ocramius
approved these changes
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #506.
Closes #507.
Closes #510.