Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed outdated @psalm-suppress #593

Merged
merged 1 commit into from
May 26, 2020
Merged

Removed outdated @psalm-suppress #593

merged 1 commit into from
May 26, 2020

Conversation

kukulich
Copy link
Collaborator

@kukulich kukulich commented May 25, 2020

No description provided.

@orklah
Copy link
Contributor

orklah commented May 25, 2020

You should also be able to update psalm's baseline. That should remove two errors that were added here: #544 (comment) basically for the same reason. That was fixed by Marco too.

@kukulich
Copy link
Collaborator Author

@orklah Thanks, updated.

@kukulich kukulich changed the title Removed useless @psalm-suppress annotations Removed outdated @psalm-suppress May 26, 2020
Copy link
Member

@asgrim asgrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks @kukulich

@asgrim asgrim self-assigned this May 26, 2020
@asgrim asgrim added this to the 4.3.0 milestone May 26, 2020
@asgrim asgrim merged commit 4248f18 into Roave:master May 26, 2020
@kukulich kukulich deleted the psalm branch May 27, 2020 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants