Fix name of CalculateReflectionColumn class
#641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ocramius BC break here, are we merging for next major? |
|
@asgrim The class is marked as |
|
@kukulich so it is, that'll teach me for reviewing too quickly on my phone 🤣 |
asgrim
approved these changes
Jun 8, 2020
Ocramius
approved these changes
Jun 8, 2020
|
Aaaand I didn't read the convo about 🚢 |
Ocramius
changed the title
CalculateReflectionColumn class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is already
CalculateReflectionColumnTest(spelled correctly) that should provide test coverage for this typo fix of the class name.