bump psalm to 4.1 #705
Merged
bump psalm to 4.1 #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
approved these changes
Nov 1, 2020
| @@ -352,9 +357,13 @@ private function callStaticMethod(array $args) | |||
| */ | |||
| private function callObjectMethod(object $object, array $args) | |||
| { | |||
| return Closure::bind(function ($object, string $methodName, array $methodArgs) { | |||
| $closure = Closure::bind(function ($object, string $methodName, array $methodArgs) { | |||
There was a problem hiding this comment.
Love me some shitty PHP core API :P
Ocramius
added
dependencies
|
Hmm, MT failed due to: I think we perhaps need |
|
Yeah, seems like the bump of infection changed the result. The same can be seen here: #698 Maybe we could merge this and I can look at roave/infection-static-analysis-plugin in another PR? |
|
I would prefer keeping the build green: all automations dependend on it |
…hange CI to run the plugin
|
It's done. roave/infection-static-analysis-plugin mechanically augmented the score so the build is green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR propose upgrading Psalm to 4.1 and fixing new issues along the way.
Note1: I couldn't find a way to upgrade psalm without obliterating the composer.lock first so it has been regenerated completely, I did so with composer 2, I don't know if it could cause an issue.
Note2: There is a future BC in this commit because I changed a parameter name that didn't match with the parent. Technically, this package doesn't support PHP8 so it should be fine to do it now.
Note3: I had to set phpstan version to
0.12.25instead of^0.12.25to avoid updating it. There are errors in0.12.26that are related to covariance/contravariance with internal interfaces that can't be fixed and can't be added to ignore section of phpstan. I don't know what can be done about that.