Fix and update PHPStan to 1.3.x
#945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
requested changes
Jan 4, 2022
test/phpstan-php-version.php
Outdated
|
|
||
| return [ | ||
| 'parameters' => [ | ||
| 'phpVersion' => PHP_VERSION_ID, |
There was a problem hiding this comment.
We could also drop config.platform.php from composer.json: the reason it was added was to prevent invalid @dependabot upgrades, but we can get rid of it, if it has such an influence on other tools too...
There was a problem hiding this comment.
Yeah, "php": "~8.0.12 || ~8.1.0" might be sufficient to keep valid dependencies.
There was a problem hiding this comment.
Interesting, the changed dropped composer/package-versions-deprecated and installed ocramius/package-versions, not sure why is that :) 8812e7b
ondrejmirtes
force-pushed
the
phpstan-php-version
branch
from
13dcc98
to
8812e7b
Compare
Ocramius
added
dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the failures from #939.
The problem here is quite tricky - PHPStan complains about some PHP classes that don't exist when running on PHP 8.1, because on PHP 8.0.x these really don't exist. PHPStan uses
config.platform.phpto determine the PHP version to test against.At the same time it's funny that PHPStan doesn't complain about the same problems when running on PHP 8.0. That's because PHPStan itself loads these classes as stubs so that BetterReflection Adapter layer can work. And since PHPStan sees these classes as defined by the user, it considers them as existing.
I can't make PHPStan fail with the same errors when running on PHP 8.0, because I can't sensibly differentiate between these PHPStan-related stubs, and actual user-defined polyfills...
Here I fixed it with the same approach I use in phpstan-src - it tells PHPStan to ignore the setting from config.platform.php.