-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use enum deviceTypes instead of int #22
Conversation
Auto Format is done with Arduino IDE 2.2.1
I don't know what the effect will be if the terminal returns a value that is not in the enum. Same as with the ansi colors, defined enums for readability but just using ints to keep it straightforward for the average user. |
Fine with me. Just reject.
it was actually the wrong way to do it as only '1','2', and '3' was valid and any other UNKNOWN. |
@chlordk If you have more ideas to improve the library, just let me know! |
Oh, you got a original VT100? A physical one? That's cool. I have two ideas:
RGB colors Logfile Run this script when running PuTTY:
The above will create one new file each time. History |
No the opposite, I wished I had. Will look into the ideas later, some other projects have prio |
@chlordk Should be renamed to (what is best)
|
How about
Then it is just:
|
Created a develop branch with all experimental code enabled, including setprintingMode() Back to my other projects... |
This could be interesting to add a function for under experimental. |
Sorry for the inconvenience, I have other priorities to attend so some things including this PR is delayed. wrt the RGB functions, I added these two in the latest release, and as I do not want to get into "enum trouble" I close this PR.
|
Auto Format is done with Arduino IDE 2.2.1