Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor API to support ESP32-S3 and others #31

Closed
RobTillaart opened this issue Dec 4, 2023 · 2 comments
Closed

refactor API to support ESP32-S3 and others #31

RobTillaart opened this issue Dec 4, 2023 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@RobTillaart
Copy link
Owner

  • remove ESP32 dependencies from codebase
  • get proper dependency injection
  • probably a breaking change
@RobTillaart RobTillaart self-assigned this Dec 4, 2023
@RobTillaart RobTillaart added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 4, 2023
RobTillaart added a commit that referenced this issue Dec 4, 2023
@zalexzperez
Copy link

Is this library not compatible with the ESP32-S3?

@RobTillaart
Copy link
Owner Author

RobTillaart commented Dec 4, 2023

Is this library not compatible with the ESP32-S3?
In fact not tested (no hardware).

In the code there is a special begin() call that sets the SDA and the SCL for Wire.
This method does not work for the RP2040 and possibly for the ESP32-S3.
So by removing the ability of this library to set the pins (user should do that outside this library) the portability of the library improves.

There were reports about breaking changes between ESP32 (s1) and ESP32-S3 wrt the SPI interface. I had a similar feature in some SPI libraries to set pins that should be set outside those libs. So I decided to remove all the pin settings in my libraries that should be done outside the libraries. And I copied more or less the issue title.

Furthermore I have encountered other problems with a ESP32-S3 boards / compiler that e.g. redefines analogWrite() which causes problems with existing libraries. So my goal of this action is to reduce dependencies of ESP32 code.

FYI, I still have about 70 libraries to check and update coming months (keeps me busy during the long winter evenings).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants