PyOpenSci REVIEW - Refactor code to meet PEP8 #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR addressing reviewer (@Batalex) comments in PyOpenSci:
This may be useful if contributions to Pynteny grow with time.
Right. I wrote class CommandArgs to be able to re-use subcommands defined in module pynteny/subcommands.py when calling pynteny as a module rather than from its CLI. So, in effect, subcommands take as arguments objects of class either
argparse.ArgumentParser
orCommandArgs
. It works because both contain the same required attributes. I see this is a working but not elegant solution. I could indeed instantiateCommandArgs
fromargparse.ArgumentParser
before calling each subcommand from the CLI.Taken care of.