Replaced procfs dependent functions with native calls on OS X. #87

[JanSimek]

I started replacing functions in linux_main.cpp which rely on procfs with OS X native calls and separating the two by #ifdefs

In the end it looked really confusing, so I decided to move all the common functions into posix_main.cpp and separate platform specific ones into platform_linux.cpp and platform_osx.mm (contains objective-c++ code). It's not finished, it's not tested on linux and it breaks clang build (gcc compilation works) with this error:

error: Objective-C 1 was disabled in PCH file but is currently enabled

I wasn't sure if you were going to like this solution, so I submitted this pull request first before working on it further.

[RobertBeckebans]

Is Objective-C++ really necessary? I personally hate all that
Objective-C/C++ stuff and don't want to merge it if it isn't absolutely
necessary.

2014-05-21 23:38 GMT+02:00 Radegast notifications@github.com:

I started replacing functions in linux_main.cpp which rely on procfs with
OS X native calls and separating the two by #ifdefs

In the end it looked really confusing, so I decided to move all the common
functions into posix_main.cpp and separate platform specific ones into
platform_linux.cpp and platform_osx.mm (contains objective-c++ code).
It's not finished, it's not tested on linux and it breaks clang build (gcc
compilation works) with this error:

error: Objective-C 1 was disabled in PCH file but is currently enabled

I wasn't sure if you were going to like this solution, so I submitted this

pull request first before working on it further.

You can merge this Pull Request by running

git pull https://github.com/JanSimek/RBDOOM-3-BFG objective-c

Or view, comment on, or merge it at:

#125
Commit Summary

• Replaced procfs dependent functions with native calls on OS X. Mac OS X port #87

File Changes

• M neo/CMakeLists.txthttps://github.com/Replaced procfs dependent functions with native calls on OS X. #87 #125/files#diff-0(27)
• M neo/framework/Licensee.hhttps://github.com/Replaced procfs dependent functions with native calls on OS X. #87 #125/files#diff-1(8)
• M neo/idlib/Str.hhttps://github.com/Replaced procfs dependent functions with native calls on OS X. #87 #125/files#diff-2(5)
• R neo/sys/posix/platform_linux.cpphttps://github.com/Replaced procfs dependent functions with native calls on OS X. #87 #125/files#diff-3(211)
• M neo/sys/posix/posix_main.cpphttps://github.com/Replaced procfs dependent functions with native calls on OS X. #87 #125/files#diff-4(241)
• M neo/sys/posix/posix_public.hhttps://github.com/Replaced procfs dependent functions with native calls on OS X. #87 #125/files#diff-5(2)

Patch Links:

• https://github.com/RobertBeckebans/RBDOOM-3-BFG/pull/125.patch
• https://github.com/RobertBeckebans/RBDOOM-3-BFG/pull/125.diff

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/125
.

[JanSimek]

It's not absolutely necessary. There is just no native C++ function for finding user's Application Support path, so I hard coded it to sprintf( savepath, "%s/Library/Application Support/rbdoom3bfg", getenv( "HOME" ) ); which will work until Apple changes that location. So now it compiles with both gcc and clang and there is no objective-c++ code anymore.

[DanielGibson]

Does this maybe help?
https://wiki.libsdl.org/SDL_GetPrefPath

[JanSimek]

Yes! That works.