Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Background, Display Tags in Search View #84

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

PhocaCz
Copy link

@PhocaCz PhocaCz commented Jul 18, 2016

3 new commits:

  1. Fixed problem with background image, see the description of this problem:
    https://www.phpbb.com/community/viewtopic.php?f=456&t=2263616&p=14479291#p14476431
    Background problem

  2. Displaying tags in search view (function):

  • Your Posts
  • New Posts
  • Unread Posts
  • Unanswered Topics
  • Active Topics
  1. Displaying tags in search view (template)

Fixed problem with background when displaying tag list
Display the tags in search view:
- your posts
- new posts
- unread posts
- unanswered topics
- active topics
Display the tags in search view
@PhocaCz PhocaCz changed the title Background - tag list Fixed Background, Display Tags in Search View Jul 18, 2016
@@ -1,4 +1,7 @@
<!-- IF topicrow.RH_TOPICTAGS_TAGS -->
{topicrow.RH_TOPICTAGS_TAGS}
<div class="rh_tags-view">{topicrow.RH_TOPICTAGS_TAGS}</div>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why adding wrappers? are they used anywere?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello i am not able to install on my forum 3.3.0 its showing blank page after enable all forum

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can try again using the master branch (it supports 3.3x.x now)

@RobertHeim
Copy link
Owner

Hi, thanks for collaborating!! Find some annotations above, could you please incorporate them?

@PhocaCz
Copy link
Author

PhocaCz commented Jul 19, 2016

Hi,

  1. wrappers - they are not needed but they can help when modifying output per CSS, see example
    Topic Tags
    there is need to style different views differently so this is why they have different class names

  2. rh_topictags - if this will fix the problem with displaying, then yes, of course

  3. search_modify_tpl_ary - yes, the function is in fact copied from viewforum_modify_topicrow. There is one other small issue:
    if ($this->config[prefixes::CONFIG.'_display_tags_in_viewforum'])

Maybe there should be new config value for search view, for now the viewforum config is used, so it is in fact not correct.

Please, take this pull request as inspiration, I am new to phpBB coding, so for example, I am not able to do config parameter for the displaying in search view, etc. If you like the changes and you have idea how to implement the changes better way, please use your way.

Thank you.

@jlgager24
Copy link

Thanks so much for this! It fixed the problem!

@theantnest
Copy link

Has this extension been abandoned?

@Galixte
Copy link

Galixte commented Oct 27, 2017

@theantnest, One year without any update, I think so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants