Display bug: Tag changes in HTML template #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attoPascal
changed the title
RobertHeim
reviewed
Mar 27, 2017
| @@ -47,9 +47,11 @@ <h2 class="forum-title">{RH_TOPICTAGS_SEARCH_HEADER}</h2> | |||
| <!-- EVENT viewforum_body_topic_row_before --> | |||
| <li class="row<!-- IF topicrow.S_ROW_COUNT is even --> bg1<!-- ELSE --> bg2<!-- ENDIF --><!-- IF topicrow.S_POST_GLOBAL --> global-announce<!-- ENDIF --><!-- IF topicrow.S_POST_ANNOUNCE --> announce<!-- ENDIF --><!-- IF topicrow.S_POST_STICKY --> sticky<!-- ENDIF --><!-- IF topicrow.S_TOPIC_REPORTED --> reported<!-- ENDIF -->"> | |||
| <!-- EVENT viewforum_body_topic_row_prepend --> | |||
| <dl class="row-item {topicrow.TOPIC_IMG_STYLE}"> | |||
There was a problem hiding this comment.
What was the source of your comparison? As on the official phpbb 3.2.x branch [1], the dl tag has the class="row-item"
[1] https://github.com/phpbb/phpbb/blob/3.2.x/phpBB/styles/prosilver/template/viewforum_body.html#L158
There was a problem hiding this comment.
You're right, it appears to be a quirk of the we_universal theme: https://github.com/melvingb/we_universal/blob/master/template/viewforum_body.html#L157
Still, it's one of the most popular ones, pity that it doesn't work out of the box.
| @@ -108,7 +110,7 @@ <h2 class="forum-title">{RH_TOPICTAGS_SEARCH_HEADER}</h2> | |||
|
|
|||
| <!-- EVENT topiclist_row_append --> | |||
| </div> | |||
| </dt> | |||
There was a problem hiding this comment.
| @@ -47,9 +47,11 @@ <h2 class="forum-title">{RH_TOPICTAGS_SEARCH_HEADER}</h2> | |||
| <!-- EVENT viewforum_body_topic_row_before --> | |||
| <li class="row<!-- IF topicrow.S_ROW_COUNT is even --> bg1<!-- ELSE --> bg2<!-- ENDIF --><!-- IF topicrow.S_POST_GLOBAL --> global-announce<!-- ENDIF --><!-- IF topicrow.S_POST_ANNOUNCE --> announce<!-- ENDIF --><!-- IF topicrow.S_POST_STICKY --> sticky<!-- ENDIF --><!-- IF topicrow.S_TOPIC_REPORTED --> reported<!-- ENDIF -->"> | |||
| <!-- EVENT viewforum_body_topic_row_prepend --> | |||
| <dl class="row-item {topicrow.TOPIC_IMG_STYLE}"> | |||
| <dt<!-- IF topicrow.TOPIC_ICON_IMG and S_TOPIC_ICONS --> style="background-image: url({T_ICONS_PATH}{topicrow.TOPIC_ICON_IMG}); background-repeat: no-repeat;"<!-- ENDIF --> title="{topicrow.TOPIC_FOLDER_IMG_ALT}"> | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I compared the HTML structure of your
show_tagtemplate and the standard phpBB topic view and found some minor differences. So I made the appropriate changes to the template, which fixed the display bug in the we_universal theme.Compare https://www.phpbb.com/community/viewtopic.php?f=456&t=2263616&start=240#p14476431
I suppose that with some further tweaks the CSS workaround from #84 shouldn't be needed anymore.