Removeing the unecessary / 's in index.html as it breaks reverse proxying into a sub folder. #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is just a minor fix, but I found that the /'s before sounds break reverse proxying into a subfolder with traefik.
Benefits of this PR and context:
It doesn't break any existing functionality and works in the context I tested.
How Has This Been Tested?
I was initially using linuxserver/snapdrop but then I edited the Dockerfiles to make the build work.
added this line to the Dockerfile
sed -i 's#/sounds#sounds#g' /app/www/client/index.html && \I have tested it on arm64 (raspberry pi 4b+) and amd64.