Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Using the configured logger for debugging uploads #1623

Merged
merged 6 commits into from
Mar 16, 2024

Conversation

RobinTail
Copy link
Owner

I made the logger in express-fileupload configurable:
richardgirges/express-fileupload#371

So now the configured logger can be used for debugging the upload instead of console.
That, however, also requires the types updated in a separate repo (waiting for that):
DefinitelyTyped/DefinitelyTyped#69016

@RobinTail RobinTail added enhancement New feature or request dependencies Pull requests that update a dependency file labels Mar 16, 2024
src/server.ts Outdated Show resolved Hide resolved
Copy link

coveralls-official bot commented Mar 16, 2024

Coverage Status

coverage: 100.0%. remained the same
when pulling bd18cb3 on feat-logging-upload
into 12c0775 on master.

@RobinTail RobinTail added the documentation Improvements or additions to documentation label Mar 16, 2024
@RobinTail RobinTail marked this pull request as ready for review March 16, 2024 15:44
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@RobinTail RobinTail merged commit b0e8bdf into master Mar 16, 2024
11 checks passed
@RobinTail RobinTail deleted the feat-logging-upload branch March 16, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant