-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding logger
option for express-fileupload
#69016
Adding logger
option for express-fileupload
#69016
Conversation
@RobinTail Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69016,
"author": "RobinTail",
"headCommitOid": "c98addb2aa827811610f458e28d1364256482f50",
"mergeBaseOid": "fd3a4412cefa743e3c49d076a2f109e9fab6d611",
"lastPushDate": "2024-03-16T08:51:08.000Z",
"lastActivityDate": "2024-03-18T20:00:34.000Z",
"mergeOfferDate": "2024-03-18T20:00:04.000Z",
"mergeRequestDate": "2024-03-18T20:00:34.000Z",
"mergeRequestUser": "RobinTail",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "express-fileupload",
"kind": "edit",
"files": [
{
"path": "types/express-fileupload/express-fileupload-tests.ts",
"kind": "test"
},
{
"path": "types/express-fileupload/index.d.ts",
"kind": "definition"
},
{
"path": "types/express-fileupload/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"silkimen",
"peterblazejewicz",
"markxoe",
"BendingBender"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "peterblazejewicz",
"date": "2024-03-18T19:59:23.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 2001917086,
"ciResult": "pass"
} |
🔔 @silkimen @peterblazejewicz @markxoe @BendingBender — please review this PR in the next few days. Be sure to explicitly select |
I made the logger in `express-fileupload` configurable: richardgirges/express-fileupload#371 So now the configured logger can be used for debugging the upload instead of console. That, however, also requires the types updated in a separate repo (waiting for that): DefinitelyTyped/DefinitelyTyped#69016
@peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RobinTail thanks!
@RobinTail: Everything looks good here. I am ready to merge this PR (at c98addb) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@silkimen, @peterblazejewicz, @markxoe, @BendingBender: you can do this too.) |
Ready to merge , @typescript-bot |
I'm adding the type of a new option I added myself to that package. The changes are released in version 1.5.0. Tests are updated, and I tested the changes manually in a real project.
Please fill in this template.
pnpm test <package to test>
.If changing an existing definition:
package.json
.