Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding logger option for express-fileupload #69016

Conversation

RobinTail
Copy link
Contributor

@RobinTail RobinTail commented Mar 16, 2024

I'm adding the type of a new option I added myself to that package. The changes are released in version 1.5.0. Tests are updated, and I tested the changes manually in a real project.

Please fill in this template.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: PR 371: Custom logger
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

@RobinTail RobinTail marked this pull request as ready for review March 16, 2024 08:52
@typescript-bot
Copy link
Contributor

typescript-bot commented Mar 16, 2024

@RobinTail Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69016,
  "author": "RobinTail",
  "headCommitOid": "c98addb2aa827811610f458e28d1364256482f50",
  "mergeBaseOid": "fd3a4412cefa743e3c49d076a2f109e9fab6d611",
  "lastPushDate": "2024-03-16T08:51:08.000Z",
  "lastActivityDate": "2024-03-18T20:00:34.000Z",
  "mergeOfferDate": "2024-03-18T20:00:04.000Z",
  "mergeRequestDate": "2024-03-18T20:00:34.000Z",
  "mergeRequestUser": "RobinTail",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "express-fileupload",
      "kind": "edit",
      "files": [
        {
          "path": "types/express-fileupload/express-fileupload-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/express-fileupload/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/express-fileupload/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "silkimen",
        "peterblazejewicz",
        "markxoe",
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2024-03-18T19:59:23.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 2001917086,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label Mar 16, 2024
@typescript-bot
Copy link
Contributor

🔔 @silkimen @peterblazejewicz @markxoe @BendingBender — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

RobinTail added a commit to RobinTail/express-zod-api that referenced this pull request Mar 16, 2024
I made the logger in `express-fileupload` configurable:
richardgirges/express-fileupload#371

So now the configured logger can be used for debugging the upload
instead of console.
That, however, also requires the types updated in a separate repo
(waiting for that):
DefinitelyTyped/DefinitelyTyped#69016
@typescript-bot
Copy link
Contributor

@peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

Copy link
Member

@peterblazejewicz peterblazejewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RobinTail thanks!

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Mar 18, 2024
@typescript-bot
Copy link
Contributor

@RobinTail: Everything looks good here. I am ready to merge this PR (at c98addb) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@silkimen, @peterblazejewicz, @markxoe, @BendingBender: you can do this too.)

@RobinTail
Copy link
Contributor Author

Ready to merge , @typescript-bot

@typescript-bot typescript-bot merged commit 9f95a37 into DefinitelyTyped:master Mar 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintainer Approved Popular package This PR affects a popular package (as counted by NPM download counts). Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants