Non-breaking: upgrading typescript-eslint group and testing Jest 30 #1627

RobinTail · 2024-03-18T19:57:30Z

Bump the typescript-eslint group with 2 updates #1625
Partial: Supporting jest v30 #1542 (compatibility testing only, no support yet)
Ignoring engines for devDependencies only #1633

Bumps the typescript-eslint group with 2 updates: [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) and [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser). Updates `@typescript-eslint/eslint-plugin` from 7.2.0 to 7.3.0 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/releases"><code>@typescript-eslint/eslint-plugin</code>'s releases</a>.</em></p> <blockquote> <h2>v7.3.0</h2> <h2>7.3.0 (2024-03-18)</h2> <h3>🚀 Features</h3> <ul> <li><strong>eslint-plugin:</strong> [restrict-template-expressions] add <code>allowArray</code> option (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8389">#8389</a>)</li> <li><strong>eslint-plugin:</strong> add meta.docs.recommended setting for strict config options (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8364">#8364</a>)</li> <li><strong>eslint-plugin:</strong> add rule <code>use-unknown-in-catch-callback-variables</code> (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8383">#8383</a>)</li> <li><strong>eslint-plugin:</strong> [prefer-reduce-type-parameter] supports tuple, union, intersection (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8642">#8642</a>)</li> <li><strong>eslint-plugin-internal:</strong> add internal lint rule no-relative-paths-to-internal-packages (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8596">#8596</a>)</li> <li><strong>typescript-estree:</strong> disallow switch statements with multiple default cases (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8411">#8411</a>)</li> <li><strong>utils:</strong> add parser name to thrown parser error message (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8484">#8484</a>)</li> </ul> <h3>🩹 Fixes</h3> <ul> <li>correct <code>engines.node</code> constraints in <code>package.json</code> (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8671">#8671</a>)</li> <li><strong>eslint-plugin:</strong> [unbound-method] check method definition in object literal using longhand form (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8637">#8637</a>)</li> <li><strong>eslint-plugin:</strong> [consistent-type-imports] handle imports without specifiers (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8308">#8308</a>)</li> <li><strong>eslint-plugin:</strong> [no-redundant-type-constituents] incorrectly marks & string as redundant (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8282">#8282</a>)</li> <li><strong>eslint-plugin:</strong> [no-unnecessary-qualifier] handle merge namespace with enum (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8591">#8591</a>)</li> <li><strong>eslint-plugin:</strong> [no-unused-expressions] false negatives when using assertions (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8668">#8668</a>)</li> <li><strong>eslint-plugin:</strong> [ban-ts-comment] more accurate handling of multiline comments (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8416">#8416</a>)</li> <li><strong>eslint-plugin:</strong> [explicit-function-return-type, explicit-module-boundary-types] improved checking for allowHigherOrderFunctions option (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8508">#8508</a>)</li> <li><strong>eslint-plugin:</strong> [class-literal-property-style] ignore property assigned in constructor (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8412">#8412</a>)</li> <li><strong>eslint-plugin:</strong> [no-unnecessary-type-assertion] fix false negative for const variable declarations (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8558">#8558</a>)</li> <li><strong>typescript-estree:</strong> fix the issue of single run inferring in the pnpm repo (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/3811">#3811</a>, <a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8702">#8702</a>)</li> </ul> <h3>❤️ Thank You</h3> <ul> <li>Abraham Guo</li> <li>Alexu</li> <li>Arka Pratim Chaudhuri <a href="https://github.com/arka1002"><code>@arka1002</code></a></li> <li>auvred <a href="https://github.com/auvred"><code>@auvred</code></a></li> <li>Derrick Isaacson</li> <li>fnx <a href="https://github.com/DMartens"><code>@DMartens</code></a></li> <li>Josh Goldberg ✨</li> <li>Kirk Waiblinger <a href="https://github.com/kirkwaiblinger"><code>@kirkwaiblinger</code></a></li> <li>Marta Cardoso <a href="https://github.com/up201304504"><code>@up201304504</code></a></li> <li>Michaël De Boey</li> <li>Tristan Rasmussen</li> <li>YeonJuan <a href="https://github.com/yeonjuan"><code>@yeonjuan</code></a></li> </ul> <p>You can read about our <a href="https://main--typescript-eslint.netlify.app/users/versioning">versioning strategy</a> and <a href="https://main--typescript-eslint.netlify.app/users/releases">releases</a> on our website.</p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md"><code>@typescript-eslint/eslint-plugin</code>'s changelog</a>.</em></p> <blockquote> <h2>7.3.0 (2024-03-18)</h2> <h3>🚀 Features</h3> <ul> <li> <p><strong>eslint-plugin:</strong> [restrict-template-expressions] add <code>allowArray</code> option</p> </li> <li> <p><strong>eslint-plugin:</strong> add meta.docs.recommended setting for strict config options</p> </li> <li> <p><strong>eslint-plugin:</strong> add rule <code>use-unknown-in-catch-callback-variables</code></p> </li> <li> <p><strong>eslint-plugin:</strong> [prefer-reduce-type-parameter] supports tuple, union, intersection</p> </li> </ul> <h3>🩹 Fixes</h3> <ul> <li> <p>correct <code>engines.node</code> constraints in <code>package.json</code></p> </li> <li> <p><strong>eslint-plugin:</strong> [unbound-method] check method definition in object literal using longhand form</p> </li> <li> <p><strong>eslint-plugin:</strong> [consistent-type-imports] handle imports without specifiers</p> </li> <li> <p><strong>eslint-plugin:</strong> [no-redundant-type-constituents] incorrectly marks & string as redundant</p> </li> <li> <p><strong>eslint-plugin:</strong> [no-unnecessary-qualifier] handle merge namespace with enum</p> </li> <li> <p><strong>eslint-plugin:</strong> [no-unused-expressions] false negatives when using assertions</p> </li> <li> <p><strong>eslint-plugin:</strong> [ban-ts-comment] more accurate handling of multiline comments</p> </li> <li> <p><strong>eslint-plugin:</strong> [explicit-function-return-type, explicit-module-boundary-types] improved checking for allowHigherOrderFunctions option</p> </li> <li> <p><strong>eslint-plugin:</strong> [class-literal-property-style] ignore property assigned in constructor</p> </li> <li> <p><strong>eslint-plugin:</strong> [no-unnecessary-type-assertion] fix false negative for const variable declarations</p> </li> </ul> <h3>❤️ Thank You</h3> <ul> <li>Abraham Guo</li> <li>Alexu</li> <li>Arka Pratim Chaudhuri</li> <li>auvred</li> <li>Derrick Isaacson</li> <li>fnx</li> <li>Josh Goldberg ✨</li> <li>Kirk Waiblinger</li> <li>Marta Cardoso</li> <li>Michaël De Boey</li> <li>Tristan Rasmussen</li> </ul>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/4cf8ec7201a01141162f67da27c7bf7b886b712d"><code>4cf8ec7</code></a> chore(release): publish 7.3.0</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/d2995df028831191881079fa62e1f38dc10e2c59"><code>d2995df</code></a> fix(eslint-plugin): [no-unnecessary-type-assertion] fix false negative for co...</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/2869c68b28054bc1b69bbd0eecb58a12d015b988"><code>2869c68</code></a> feat(eslint-plugin): [prefer-reduce-type-parameter] supports tuple, union, in...</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/d830364226513f8556fe53a0901c9c0c70e05204"><code>d830364</code></a> test(eslint-plugin): [no-unnecessary-type-assertion] add tests with noUncheck...</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/04e32d6834c19160fb4f44f812a3e64671fca893"><code>04e32d6</code></a> fix(eslint-plugin): [class-literal-property-style] ignore property assigned i...</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/612875bced1cd5a197a97c58dc9a89bf9e59cd8a"><code>612875b</code></a> fix(eslint-plugin): [explicit-function-return-type, explicit-module-boundary-...</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/da006b1c9bb758b51c52c8b5af4ce43b44976e3f"><code>da006b1</code></a> fix(eslint-plugin): [ban-ts-comment] more accurate handling of multiline comm...</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/71bfb7c6fc250413ce783d57f20a686e9e210b12"><code>71bfb7c</code></a> chore: fix ast-spec type import snapshot errors (<a href="https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin/issues/8699">#8699</a>)</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/fb18de9c953ce4e90dae7e053d2e987b2dca3181"><code>fb18de9</code></a> fix(eslint-plugin): [no-unused-expressions] false negatives when using assert...</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/f7323be7ac3e9d924fb03ff6b229eede078a96bf"><code>f7323be</code></a> fix(eslint-plugin): [no-unnecessary-qualifier] handle merge namespace with en...</li> <li>Additional commits viewable in <a href="https://github.com/typescript-eslint/typescript-eslint/commits/v7.3.0/packages/eslint-plugin">compare view</a></li> </ul> </details> <br /> Updates `@typescript-eslint/parser` from 7.2.0 to 7.3.0 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/releases"><code>@typescript-eslint/parser</code>'s releases</a>.</em></p> <blockquote> <h2>v7.3.0</h2> <h2>7.3.0 (2024-03-18)</h2> <h3>🚀 Features</h3> <ul> <li><strong>eslint-plugin:</strong> [restrict-template-expressions] add <code>allowArray</code> option (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8389">#8389</a>)</li> <li><strong>eslint-plugin:</strong> add meta.docs.recommended setting for strict config options (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8364">#8364</a>)</li> <li><strong>eslint-plugin:</strong> add rule <code>use-unknown-in-catch-callback-variables</code> (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8383">#8383</a>)</li> <li><strong>eslint-plugin:</strong> [prefer-reduce-type-parameter] supports tuple, union, intersection (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8642">#8642</a>)</li> <li><strong>eslint-plugin-internal:</strong> add internal lint rule no-relative-paths-to-internal-packages (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8596">#8596</a>)</li> <li><strong>typescript-estree:</strong> disallow switch statements with multiple default cases (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8411">#8411</a>)</li> <li><strong>utils:</strong> add parser name to thrown parser error message (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8484">#8484</a>)</li> </ul> <h3>🩹 Fixes</h3> <ul> <li>correct <code>engines.node</code> constraints in <code>package.json</code> (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8671">#8671</a>)</li> <li><strong>eslint-plugin:</strong> [unbound-method] check method definition in object literal using longhand form (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8637">#8637</a>)</li> <li><strong>eslint-plugin:</strong> [consistent-type-imports] handle imports without specifiers (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8308">#8308</a>)</li> <li><strong>eslint-plugin:</strong> [no-redundant-type-constituents] incorrectly marks & string as redundant (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8282">#8282</a>)</li> <li><strong>eslint-plugin:</strong> [no-unnecessary-qualifier] handle merge namespace with enum (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8591">#8591</a>)</li> <li><strong>eslint-plugin:</strong> [no-unused-expressions] false negatives when using assertions (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8668">#8668</a>)</li> <li><strong>eslint-plugin:</strong> [ban-ts-comment] more accurate handling of multiline comments (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8416">#8416</a>)</li> <li><strong>eslint-plugin:</strong> [explicit-function-return-type, explicit-module-boundary-types] improved checking for allowHigherOrderFunctions option (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8508">#8508</a>)</li> <li><strong>eslint-plugin:</strong> [class-literal-property-style] ignore property assigned in constructor (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8412">#8412</a>)</li> <li><strong>eslint-plugin:</strong> [no-unnecessary-type-assertion] fix false negative for const variable declarations (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8558">#8558</a>)</li> <li><strong>typescript-estree:</strong> fix the issue of single run inferring in the pnpm repo (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/3811">#3811</a>, <a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8702">#8702</a>)</li> </ul> <h3>❤️ Thank You</h3> <ul> <li>Abraham Guo</li> <li>Alexu</li> <li>Arka Pratim Chaudhuri <a href="https://github.com/arka1002"><code>@arka1002</code></a></li> <li>auvred <a href="https://github.com/auvred"><code>@auvred</code></a></li> <li>Derrick Isaacson</li> <li>fnx <a href="https://github.com/DMartens"><code>@DMartens</code></a></li> <li>Josh Goldberg ✨</li> <li>Kirk Waiblinger <a href="https://github.com/kirkwaiblinger"><code>@kirkwaiblinger</code></a></li> <li>Marta Cardoso <a href="https://github.com/up201304504"><code>@up201304504</code></a></li> <li>Michaël De Boey</li> <li>Tristan Rasmussen</li> <li>YeonJuan <a href="https://github.com/yeonjuan"><code>@yeonjuan</code></a></li> </ul> <p>You can read about our <a href="https://main--typescript-eslint.netlify.app/users/versioning">versioning strategy</a> and <a href="https://main--typescript-eslint.netlify.app/users/releases">releases</a> on our website.</p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md"><code>@typescript-eslint/parser</code>'s changelog</a>.</em></p> <blockquote> <h2>7.3.0 (2024-03-18)</h2> <h3>🩹 Fixes</h3> <ul> <li>correct <code>engines.node</code> constraints in <code>package.json</code></li> </ul> <h3>❤️ Thank You</h3> <ul> <li>Abraham Guo</li> <li>Alexu</li> <li>Arka Pratim Chaudhuri</li> <li>auvred</li> <li>Derrick Isaacson</li> <li>fnx</li> <li>Josh Goldberg ✨</li> <li>Kirk Waiblinger</li> <li>Marta Cardoso</li> <li>Michaël De Boey</li> <li>Tristan Rasmussen</li> <li>YeonJuan</li> </ul> <p>You can read about our <a href="https://main--typescript-eslint.netlify.app/users/versioning">versioning strategy</a> and <a href="https://main--typescript-eslint.netlify.app/users/releases">releases</a> on our website.</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/4cf8ec7201a01141162f67da27c7bf7b886b712d"><code>4cf8ec7</code></a> chore(release): publish 7.3.0</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/883f22089df0846eab6d0c1443e5ea4cfcb9ed52"><code>883f220</code></a> fix: correct <code>engines.node</code> constraints in <code>package.json</code> (<a href="https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser/issues/8671">#8671</a>)</li> <li>See full diff in <a href="https://github.com/typescript-eslint/typescript-eslint/commits/v7.3.0/packages/parser">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Anna Bocharova <anna.bocharova@deliveryhero.com> Co-authored-by: Anna Bocharova <robin_tail@me.com>

coveralls-official · 2024-03-18T20:00:47Z

coverage: 100.0%. remained the same
when pulling 4cc642e on prep-v18
into 9d50cd7 on master.

[Jest 30](https://github.com/jestjs/jest/milestone/15) is coming soon requiring higher Node.js version. ~~Since it's an optional peer dependency I made an arrangement to avoid breaking changes in `express-zod-api` itself.~~ Addressed to v18 having min Node version 18.18.

tests/compat/package.json

package.json

RobinTail · 2024-03-19T13:06:13Z

It turned out that ESLint community has a very strange view on Node version dependency.
They set it not by the code requirements, but rather based on consideration of what LTS is.

https://github.com/eslint/eslint/issues/17595
https://github.com/eslint/eslint/pull/17725

So, perhaps I should not bend the package requirements into that questionable logic of a dev dependency.

That's how `yarn --production` should work but it does not. The idea here is to reduce the application of `--ignore-engines` only to the `devDependencies`. So that I could keep the `engines` of `express-zod-api` intact and it will reflect the requirements of the library in runtime.

.github/workflows/codeql-analysis.yml

.github/workflows/node.js.yml

.github/workflows/swagger.yml

package.json

Adjusting triggering branches.

e24af81

RobinTail added dependencies Pull requests that update a dependency file breaking Backward incompatible changes labels Mar 18, 2024

RobinTail added the CI/CD label Mar 18, 2024

RobinTail added this to the v18 milestone Mar 18, 2024

RobinTail mentioned this pull request Mar 18, 2024

Bump the typescript-eslint group with 2 updates #1628

Closed

RobinTail added 2 commits March 18, 2024 21:26

Merge branch 'master' into prep-v18

e2fb092

RobinTail commented Mar 18, 2024

View reviewed changes

tests/compat/package.json Show resolved Hide resolved

RobinTail commented Mar 18, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

RobinTail added refactoring The better way to achieve the same result and removed breaking Backward incompatible changes labels Mar 19, 2024

RobinTail changed the title ~~Next: v18~~ Non-breaking: upgrading typescript-eslint group and supporting Jest 30 Mar 19, 2024

RobinTail modified the milestone: v18 Mar 19, 2024