Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting jest v30 #1542

Merged
merged 54 commits into from
Mar 18, 2024
Merged

Supporting jest v30 #1542

merged 54 commits into from
Mar 18, 2024

Conversation

RobinTail
Copy link
Owner

@RobinTail RobinTail commented Feb 3, 2024

Jest 30 is coming soon requiring higher Node.js version.
Since it's an optional peer dependency I made an arrangement to avoid breaking changes in express-zod-api itself.

Addressed to v18 having min Node version 18.18.

@RobinTail RobinTail added dependencies Pull requests that update a dependency file CI/CD breaking Backward incompatible changes labels Feb 3, 2024
@RobinTail RobinTail added this to the v17 milestone Feb 3, 2024
@RobinTail RobinTail changed the base branch from master to prep-v17 February 3, 2024 14:00
@RobinTail
Copy link
Owner Author

Due to jestjs/jest#14460 requires at least Node 18.12

@RobinTail RobinTail mentioned this pull request Feb 3, 2024
@coveralls
Copy link

coveralls commented Feb 3, 2024

Coverage Status

coverage: 100.0%. remained the same
when pulling e100723 on try-jest-30
into e2fb092 on prep-v18.

@RobinTail
Copy link
Owner Author

Or, I can make it non-breaking by testing compatibility only on certain Node versions.

@RobinTail RobinTail removed this from the v17 milestone Feb 22, 2024
Base automatically changed from prep-v17 to master February 23, 2024 12:48
@RobinTail RobinTail changed the base branch from master to prep-v18 March 18, 2024 20:03
@RobinTail RobinTail removed the CI/CD label Mar 18, 2024
@RobinTail RobinTail marked this pull request as ready for review March 18, 2024 20:20
@RobinTail RobinTail merged commit 50a5373 into prep-v18 Mar 18, 2024
10 checks passed
@RobinTail RobinTail deleted the try-jest-30 branch March 18, 2024 20:37
@RobinTail RobinTail removed this from the v18 milestone Mar 19, 2024
RobinTail added a commit that referenced this pull request Mar 19, 2024
…1627)

- #1625 
- Partial: #1542 (compatibility testing only, no support yet)
- #1633

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants