Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using const for literals in documentation #1651

Merged
merged 12 commits into from
Apr 1, 2024
Merged

Using const for literals in documentation #1651

merged 12 commits into from
Apr 1, 2024

Conversation

RobinTail
Copy link
Owner

@RobinTail RobinTail commented Mar 29, 2024 •
edited

This is not documented well on the OpenAPI website, but it's inherited from the JSON Schema validation standard.
And it works:

image

0 problems (0 error, 0 warnings, 0 information, 0 hints)

@RobinTail RobinTail added the refactoring The better way to achieve the same result label Mar 29, 2024
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Mar 29, 2024 •
edited

Coverage Status

coverage: 100.0%. remained the same
when pulling b8aad2f on const-for-literal
into d2d9680 on master.

@RobinTail
Copy link
Owner Author

The field added to openapi3-ts, but not yet released:
metadevpro/openapi3-ts#132

@RobinTail RobinTail mentioned this pull request Apr 1, 2024
Merged
@RobinTail RobinTail marked this pull request as ready for review April 1, 2024 09:06
@RobinTail
Copy link
Owner Author

Now need this to continue: metadevpro/openapi3-ts#133

@RobinTail RobinTail mentioned this pull request Apr 1, 2024
Merged
RobinTail
RobinTail commented Apr 1, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
RobinTail
RobinTail commented Apr 1, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
RobinTail
RobinTail commented Apr 1, 2024
View reviewed changes
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready

RobinTail
RobinTail commented Apr 1, 2024
View reviewed changes
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even better

@RobinTail RobinTail added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 1, 2024
@RobinTail RobinTail merged commit 540d58a into master Apr 1, 2024
12 checks passed
@RobinTail RobinTail deleted the const-for-literal branch April 1, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request refactoring The better way to achieve the same result
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@RobinTail