Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: ability to replace the default value with a label in Documentation #1709

Merged
merged 25 commits into from
May 4, 2024

Conversation

RobinTail
Copy link
Owner

@RobinTail RobinTail commented Apr 27, 2024

According to discussion #1706

@RobinTail RobinTail added the enhancement New feature or request label Apr 27, 2024
@RobinTail RobinTail changed the title Feature 1706 Feat: ability to override the default value with a label in Documentation Apr 28, 2024
@RobinTail RobinTail changed the title Feat: ability to override the default value with a label in Documentation Feat: ability to replace the default value with a label in Documentation Apr 28, 2024
Copy link

coveralls-official bot commented Apr 29, 2024

Coverage Status

coverage: 100.0%. remained the same
when pulling fb5415b on feat-1706-default-placeholder
into 92255a3 on master.

@RobinTail RobinTail marked this pull request as ready for review April 29, 2024 19:05
@RobinTail RobinTail added the refactoring The better way to achieve the same result label Apr 29, 2024
src/metadata.ts Outdated Show resolved Hide resolved
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@RobinTail
Copy link
Owner Author

RobinTail commented May 4, 2024

Despite the new information came out recently and reflected in #1719 and #1721 , my overall disappointment on the chosen Zod's path, I decided to merge and release this feature first, and go step-by-step in the future development of the library, striving to perfection, that of course can never be achieved.

Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@RobinTail RobinTail merged commit 5b34302 into master May 4, 2024
11 checks passed
@RobinTail RobinTail deleted the feat-1706-default-placeholder branch May 4, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring The better way to achieve the same result
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant