Metadata without withMeta()
#1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinTail
changed the title
RobinTail
commented
May 1, 2024
RobinTail
changed the title
withMeta
|
The approach on altering prototypes of The final plugin implementation is here (slightly changed): |
RobinTail
changed the title
withMetawithMeta
RobinTail
force-pushed
the
meta-via-prototype
branch
from
30909f8
to
74407d8
Compare
RobinTail
force-pushed
the
meta-via-prototype
branch
from
74407d8
to
fbc32d9
Compare
|
✅ QA passed |
RobinTail
added a commit
that referenced
this pull request
May 4, 2024
RobinTail
added a commit
that referenced
this pull request
May 9, 2024
Due to #1721, colinhacks/zod#2860 (comment), and #1719 I'm exploring the possibility to alter the behaviour of `.brand()` for storing the `brand` property as a way to distinguish the proprietary schemas in runtime. This can replace the `proprietary()` function with a call of `.brand()`. However, so far it turned out to be breaking because `ZodBranded` does not expose the methods of the wrapped schema, such as `.extend()`, which is used in `accept-raw.ts` endpoint for possible route params. —— After a series of serious considerations I realized that exposing brand to consumers of `express-zod-api` could be a beneficial feature. Runtime brand can be accessed via `._def[Symbol.for("express-zod-api")].brand`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the Zod author's PR, it's kinda OK to alter Zod's prototypes:
https://github.com/colinhacks/zod/pull/3445/files#diff-d8a41ab20c64f92092513f153b78e7bbf5dc929c92909fad25e03d53c7f15bb7R21-R37
I tried to avoid that when I created
withMeta(), but since Colin is doing it themselves, this approach could be beneficial for consumers.