More flexible methods for Endpoint and Routing #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
RobinTail
commented
Jun 5, 2021
•
RobinTail
commented
- A more convenient way to specify a single method to the Endpoint.
- Ability to assign multiple Endpoints to a single Route depending on Method (the issue: Question: Different I/O for different methods #29)
- Ability for the Endpoint to handle multiple methods of the single Route at the same time
…st the corresponding one.
RobinTail
commented
Jun 5, 2021
Comment on lines
+5
to
+9
| export type MethodsDefinition<M extends Method> = { | ||
| methods: M[]; | ||
| } | { | ||
| method: M; | ||
| }; |
There was a problem hiding this comment.
Two ways to specify the Endpoint method(s).
RobinTail
added
enhancement
RobinTail
commented
Jun 5, 2021
Comment on lines
+5
to
+11
| export const v1Routing: Routing = { | ||
| // syntax 1: methods are defined within the endpoint | ||
| getUser: getUserEndpoint, | ||
| setUser: setUserEndpoint | ||
|
|
||
| // syntax 2: methods are defined within the route | ||
| setUser: new DependsOnMethod({ | ||
| post: setUserEndpoint // the Endpoint should have at least the same method specified in .build() |
There was a problem hiding this comment.
A route can have multiple handlers (with different I/O schemas) depending on different methods.
It can also be the same Endpoint that handle different methods as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.