Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update StdModule.php #1

Merged
merged 2 commits into from
Oct 13, 2020
Merged

Update StdModule.php #1

merged 2 commits into from
Oct 13, 2020

Conversation

Gulliver72
Copy link
Contributor

Fix: Check if a constant was defined to avoid a warning

@Gulliver72
Update StdModule.php
e1419f9 
Fix: Check if a constant was defined to avoid a warning
@Gulliver72
Update StdModule.php
70634ab 
fix: check if a constant was defined to avoid a warning and added a default parameter
RobinTheHood
RobinTheHood approved these changes Oct 13, 2020
View reviewed changes
Copy link
Owner

@RobinTheHood RobinTheHood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice. Thank you. 👍

@RobinTheHood RobinTheHood added the bug Something isn't working label Oct 13, 2020
@RobinTheHood RobinTheHood merged commit c4aa4e2 into RobinTheHood:master Oct 13, 2020
@Gulliver72 Gulliver72 deleted the fix-function-getSortOrder branch October 13, 2020 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobinTheHood RobinTheHood RobinTheHood approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gulliver72 @RobinTheHood