Removing camel casing for case-sensitive systems #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1. I'm having the same issue deploying to Ubuntu and CentOS machines after development work on OS X. |
|
This needs to be merged. Just spent an hour figuring out that lodash.foreach !== lodash.forEach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some operating systems (like the flavors of Linux that Heroku and Travis both run) are case-insensitive. When requiring
lodash.forEach, they'll throw an error, because the string isn't identical to the dependency's key inpackage.json.This PR resolves the issue, which is tested and running here:
Fail:
https://travis-ci.org/jonlong/static-site/builds/40857160#L384-L396
Pass:
https://travis-ci.org/jonlong/static-site/builds/40905541#L247-L250