Fix sats text on range orders #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoalaSat
commented
Jun 16, 2024
| @@ -178,7 +178,7 @@ const OrderDetails = ({ | |||
| : coordinator.info?.taker_fee ?? 0; | |||
| const defaultRoutingBudget = 0.001; | |||
| const btc_now = order.satoshis_now / 100000000; | |||
| const rate = order.amount > 0 ? order.amount / btc_now : Number(order.max_amount) / btc_now; | |||
| const rate = Number(order.max_amount ?? order.amount) / btc_now; | |||
There was a problem hiding this comment.
btc_now is calculated over max_amount if exists
There was a problem hiding this comment.
I am assuming this has been tested. Based on the change of logic alone I am not sure what the result would be (when is max_amount null | undefined? no idea), but looks like this probably fixes the issue 😄 Merging as is!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When a order with a range was taken, it shows always the value in sats for the max range, regardless the amount chosen
Checklist before merging
pip install pre-commit, thenpre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.