Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sats text on range orders #1332

Merged
merged 2 commits into from
Jun 16, 2024
Merged

Fix sats text on range orders #1332

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f989b76
Fix sats text on range orders
KoalaSat Jun 16, 2024
59a20cb
Merge branch 'main' into fix-sats-texy-on-range-order
Reckless-Satoshi Jun 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/components/OrderDetails/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ const OrderDetails = ({
: coordinator.info?.taker_fee ?? 0;
const defaultRoutingBudget = 0.001;
const btc_now = order.satoshis_now / 100000000;
const rate = order.amount > 0 ? order.amount / btc_now : Number(order.max_amount) / btc_now;
const rate = Number(order.max_amount ?? order.amount) / btc_now;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btc_now is calculated over max_amount if exists

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am assuming this has been tested. Based on the change of logic alone I am not sure what the result would be (when is max_amount null | undefined? no idea), but looks like this probably fixes the issue 😄 Merging as is!


if (isBuyer) {
if (order.amount > 0) {
Expand Down