Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cache dependencies #52

Merged
merged 19 commits into from
May 16, 2023
Merged

Feature/cache dependencies #52

merged 19 commits into from
May 16, 2023

Conversation

JAndringa
Copy link
Member

@JAndringa JAndringa commented May 2, 2023

Comments for the reviewer

  • This makes the GTests on github 500% faster by caching the build.

Pre pull request checklist:

Code Quality
  • Is the code is understandable and easy to read
  • Changes to the code comply with set clang-format rules
  • No use of manual memory control (e.g new/malloc/colloc etc)
  • Are (only) smart pointers used?
Testing
  • All tests are passing.
  • I added new / changed existing tests to reflect code changes (state why not otherwise!)
  • I tested my changes manually (Describe how, to what extent etc.)
Commit Messages
  • Commit message is saying what has been changed, why it was changed? Remember other developers might not know
    what the problem you are fixing was. Note also negative decision (e.g., why did you not do particular thing)
    TLDR: Commit message are comprehensive
  • Commit messages follows the rules of https://chris.beams.io/posts/git-commit/

@JAndringa JAndringa self-assigned this May 2, 2023
@JAndringa JAndringa linked an issue May 2, 2023 that may be closed by this pull request
@JAndringa JAndringa added the enhancement New feature or request label May 2, 2023
Copy link
Member

@silashoevers silashoevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@silashoevers silashoevers merged commit 987a672 into main May 16, 2023
@silashoevers silashoevers deleted the feature/cacheDependencies branch May 16, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache dependencies
2 participants