Fix 'unable to import a library that had some code in a 'src' subfolder... #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robot-Will
added a commit
that referenced
this pull request
Nov 21, 2013
Fix 'unable to import a library that had some code in a 'src' subfolder...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, had trouble getting my head around it, but I was unable to import a library that had some code in a 'src' subfolder.
It turns out there is a check in sketch.py, method expandCoreFolder that checks for a subfolder named src, and if so (I imagine because of some particular structure in the core arduino libraries) it skips including the main folder in the list of folders to be checked for include files.
I changed the method so that it checks whether the folder in question is in the arduino application path, and skip this particular behaviour for folders not in there (i.e. the sketchbook libraries folder):