appveyor builds occasionally fail for node 16 & 17 (#828)

* Removed node17 from release scope
* rRadded signal tests that were commented out during dev
* Appveyor.yml - reversed the order of node versions to be in decending
order, e.g., 17, 16, ... Doing this will speed up identifying build
failures and debug-fix iterations.
* Updated appveyor ament_python env to pt to python310
* Fix countPublishers() test

.circleci/config.yml

@@ -52,9 +52,7 @@ jobs:
     # setup nvm
     - run: wget -qO- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.1/install.sh | bash
     - run: echo "source $HOME/.bashrc" >> ~/.bash_profile
-    # run test suite for node 12, 14, 16, 17
-    - run_tests:
-        node_version: v17
+    # run test suite for node 12, 14, 16
     - run_tests:
         node_version: lts/gallium
     - run_tests:

.travis.yml

@@ -11,7 +11,6 @@ script:
   - 'if [ "$DOCKER_USERNAME" != "" ]; then sudo docker login -u $DOCKER_USERNAME -p $DOCKER_PASSWORD; fi'
   - sudo docker pull ubuntu:focal
   - sudo docker build -t rcldocker .
-  - docker run -v $(pwd):/ros2/rclnodejs --rm rcldocker bash -i -c  '\. $NVM_DIR/nvm.sh && nvm use v17 && cd /ros2/rclnodejs && /usr/bin/cppcheck --suppress=syntaxError --enable=all src/*.cpp src/*.hpp && cp -R /ros2/rclnodejs ~/rclnodejs && chown -R rclnodejs-user ~/rclnodejs && cd ~/rclnodejs && ./scripts/build.sh && npm test'
   - docker run -v $(pwd):/ros2/rclnodejs --rm rcldocker bash -i -c  '\. $NVM_DIR/nvm.sh && nvm use v16 && cd /ros2/rclnodejs && /usr/bin/cppcheck --suppress=syntaxError --enable=all src/*.cpp src/*.hpp && cp -R /ros2/rclnodejs ~/rclnodejs && chown -R rclnodejs-user ~/rclnodejs && cd ~/rclnodejs && ./scripts/build.sh && npm test'
   - docker run -v $(pwd):/ros2/rclnodejs --rm rcldocker bash -i -c  '\. $NVM_DIR/nvm.sh && nvm use v14 && cp -R /ros2/rclnodejs ~/rclnodejs && chown -R rclnodejs-user ~/rclnodejs && cd ~/rclnodejs && ./scripts/build.sh && npm test'
   - docker run -v $(pwd):/ros2/rclnodejs --rm rcldocker bash -i -c  '\. $NVM_DIR/nvm.sh && nvm use v12 && cp -R /ros2/rclnodejs ~/rclnodejs && chown -R rclnodejs-user ~/rclnodejs && cd ~/rclnodejs && ./scripts/build.sh && npm test'

Dockerfile

@@ -60,4 +60,3 @@ RUN  bash -c "\. .nvm/nvm.sh && nvm install v10.23.1"
 RUN  bash -c "\. .nvm/nvm.sh && nvm install lts/erbium"
 RUN  bash -c "\. .nvm/nvm.sh && nvm install lts/fermium"
 RUN  bash -c "\. .nvm/nvm.sh && nvm install lts/gallium"
-RUN  bash -c "\. .nvm/nvm.sh && nvm install v17"

README.md

@@ -40,7 +40,7 @@ rclnodejs.init().then(() => {
 
 Before installing `rclnodejs` please ensure the following software is installed and configured on your system:
 
-- [Nodejs](https://nodejs.org/en/) version between 10.23.1 - 17.x.
+- [Nodejs](https://nodejs.org/en/) version between 10.23.1 - 16.x.
 
 - [ROS 2 SDK](https://index.ros.org/doc/ros2/Installation/) for details.
   **DON'T FORGET TO [SOURCE THE ROS 2 SETUP FILE](https://index.ros.org/doc/ros2/Tutorials/Configuring-ROS2-Environment/#source-the-setup-files)**

appveyor.yml

@@ -10,11 +10,10 @@ environment:
   PYTHON3: "c:\\Python310-x64"
   PYTHON2: "c:\\Python27"
   matrix:
-    - nodejs_version: "10"
-    - nodejs_version: "12"
-    - nodejs_version: "14"
     - nodejs_version: "16"
-    - nodejs_version: "17"
+    - nodejs_version: "14"
+    - nodejs_version: "12"
+    - nodejs_version: "10"
 
 clone_folder: c:\proj\rclnodejs
 
@@ -37,7 +36,7 @@ before_build:
   - 7z x -y "c:\download\ros2-package-windows-AMD64.zip" -o"c:\" > nul
   - setx -m OPENSSL_CONF C:\OpenSSL-v111-Win64\bin\openssl.cfg
   - set PATH=C:\OpenSSL-v111-Win64\bin;%PATH%
-  - setx AMENT_PYTHON_EXECUTABLE "c:\Python39"
+  - setx AMENT_PYTHON_EXECUTABLE "c:\Python310"
   - refreshenv
   - "SET PATH=%PYTHON3%;%PYTHON3%\\bin;%PYTHON3%\\Scripts;%PATH%"
   - python -m pip install -U wheel catkin_pkg cryptography empy ifcfg lark-parser lxml netifaces numpy opencv-python pyparsing pyyaml setuptools colcon-common-extensions

scripts/npmjs-readme.md

@@ -18,7 +18,7 @@ rclnodejs.init().then(() => {
 
 **Node.js**
 
-- [Node.js](https://nodejs.org/en/) version between 8.12 - 17.x.
+- [Node.js](https://nodejs.org/en/) version between 10.23 - 16.x.
 
 **ROS 2 SDK**
 

test/test-node-oo.js

@@ -396,13 +396,15 @@ describe('rcl node methods testing', function () {
     assert.strictEqual(currentNode.namespace, '/my_ns');
   });
 
-  it('node.countPublishers', function () {
+  it('node.countPublishers', async () => {
     assert.strictEqual(node.countPublishers('chatter'), 0);
 
     node.createPublisher(RclString, 'chatter');
+    await assertUtils.createDelay(500);
     assert.strictEqual(node.countPublishers('chatter'), 1);
 
     node.createPublisher(RclString, 'chatter');
+    await assertUtils.createDelay(500);
     assert.strictEqual(node.countPublishers('chatter'), 2);
   });