Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Free memory allocated for typed arrays #843

Closed
wants to merge 1 commit into from
Closed

Conversation

minggangw
Copy link
Member

This patch fixed the memory leak when using typed arrays on nodejs > 10

Fix: #842

This patch fixed the memory leak when using typed arrays on nodejs > 10

Fix: #842
@minggangw minggangw changed the base branch from develop to galactic-geochelone April 2, 2022 09:11
@minggangw minggangw changed the base branch from galactic-geochelone to develop April 5, 2022 15:19
@wayneparrott
Copy link
Collaborator

@minggangw bummer that dtslint is failing the test suite because of transposed union types, e.g.,

Error: /home/runner/work/rclnodejs/rclnodejs/test/types/main.ts:319:1
ERROR: 319:1  expect  TypeScript@4.7 expected type to be:
  Duration | Time
got:
  Time | Duration
ERROR: 322:1  expect  TypeScript@4.7 expected type to be:
  Duration | Time
got:
  Time | Duration

We saw this a while back.
I'll give it a look asap.

@wayneparrott
Copy link
Collaborator

See PRs #847 and #848 which combined should fix the linux workflow failures.

@minggangw minggangw closed this Jun 16, 2022
@minggangw minggangw deleted the fix-issue-842 branch June 20, 2022 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v0.21.2 Release
Awaiting triage
Development

Successfully merging this pull request may close these issues.

Memory Leak when subscribing to messages containing UInt8Array
2 participants