-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding defragmentation capability and rosbridge_server_tcp #48
Conversation
Not sure why the travis build failed. Looks like it couldn't find the travis.yml file even though its there? Not a problem though, we can ignore the failure since the tests were removed until we fix it. Nice work! @baalexander I'll leave the final merge up to you. |
Thanks for the pull request and thanks for adding TCP support @ipa-fxm-db! I'm going to pull in the changes and tweak a few minor things (comments, etc.) and test it all out tomorrow. You have some TODO items in the code, are you planning on finishing those soon? If not, I'm going to move those tomorrow from code to GitHub issues. |
Hi Brandon, please feel free to move the TODO items to github issues. |
I pulled in your changes locally @ipa-fxm-db and tweaked a few things. The changes can be seen on my defragmentation branch. I mainly reorganized the comments, moved the todo items to a ticket, added a rosbridge_tcp launch file, and moved rosbridge_tcp to scripts. Your code was targeted for fuerte-devel. Was this intentional? For my defragmentation branch, I cherry-picked your changes on top of our groovy-devel branch. If merging this into groovy-devel is okay by you, do you mind adding unit tests to defragmentation.py? The code is complex enough I would feel safer with some testing in place. If you make any changes, you can pull from my branch first to get my edits. You can do this by either cloning my repository and performing a |
@baalexander: yes, the code was targeted for fuerte. I think it should work with groovy too. I will think about adding some unit tests.. you're right, it has enought complexity for testing that way. especially the timeouts.. and also reconstruction depending on correct JSON-parsing etc.. I will update on this when I decide to write some tests. |
I noticed an error in the line before the last one in defragmentation.py: should be: |
Thanks @ipa-fxm-db! If you want to keep targeting Fuerte-devel, you can cherry-pick my changes in the demonstrated branch. Or if you would like to target groovy-devel, you can use my branch as a starting point and we can work on back porting it to Fuerte when the tests are complete. |
Feel free to give feedback to this pull request!