[NEW] ros2 - Adaptaions to Eloquent #531
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adapt rosbridge_suite to ROS2 Eloquent - increase spin period to 1000Hz to allow 1000 messages per second into the websocket - increase parsing speed of sensor_msgs/CompressedImage - add some debug messages - allow interpreting int as float when needed - better handling array.array and numpy arrays - allow bytes and str websocket messages
- adapt rosbridge_suite to ROS2 Eloquent - increase spin period to 1000Hz to allow 1000 messages per second into the websocket - increase parsing speed of sensor_msgs/CompressedImage - add some debug messages - allow interpreting int as float when needed - better handling array.array and numpy arrays - allow bytes and str websocket messages Contributors: @joshwapohlmann @mmatthe
- remove extraneous print statements - remove unused packages - remove whitespace - move message conversion to str into websocket_handler
Adding a dict `shortcut_object_decoders` that contains functions that handles decoding of specific objects quicker than the generic method. remove requirements.txt Co-authored-by: joshwapohlmann <joshwa.pohlmann@barkhauseninstitut.org>
Co-Authored-by: joshwapohlmann <joshwa.pohlmann@barkhauseninstitut.org>
|
I can't see the difference between this and #493 and the same feedback applies. |
|
@mvollrath @AviKenz I hate to see 3 similar PRs open at once, but it seems this PR is not an extension, but rather a duplicate of #493 . So I have opened another PR over at #533 which includes all of the same fixes, plus more, while omitting the offending section that was previously holding things up. @AviKenz As this is the same as #493 I'd recommend closing this PR and moving the conversation over to #533 where I'm happy to make any small adjustments for it to be approved and merged. |
|
Thank you @travipross 😃😃😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone !
This PR is just a duplicate of ros2 - Adaptations to Eloquent.
@mmatthe didn't update the old one since a while now and some changes request are still open.
I am not a ROS or Python expert :) but i think i am able to write some if...else condition or add/remove some comments to get this PR merged.
Check my motivations HERE :)
so let me know what should be changed to get this done :)