Fixed /get_param service for arrays #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a missing comma which resulted in wrong mapping of array types.
jtbandes
approved these changes
Aug 12, 2022
jihoonl
pushed a commit
to floatic-unicorn/rosbridge_suite
that referenced
this pull request
Oct 6, 2022
**Public API Changes** None **Description** The missing comma resulted in a wrong mapping of array parameters. For example, requesting a string array only returned an empty value because the type was given as index 9 (entry 10) but the type_mapping only had 9 entries. The error should be obvious, so I have not included an extra test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public API Changes
None
Description
The missing comma resulted in a wrong mapping of array parameters. For example, requesting a string array only returned an empty value because the type was given as index 9 (entry 10) but the type_mapping only had 9 entries.
The error should be obvious, so I have not included an extra test.