Added repubServiceName parameter to TFClient. #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This parameter is needed if your tf2_web_republisher is running in a namesspace.
|
I'm sorry but I have no clue why this PR is failing on nodejs 0.12. I'm not doing fancy magic here. Additionally, the failing test uses the groovy compatibility and shouldn't be directly influenced by this PR. |
|
Oh ok now all three tests passed. |
|
I re-trigggered the test, looks good :) Thanks for the contribution! |
|
I fixed the startup race condition in #204, but its not yet merged. |
|
sweet, thanks :) |
|
👍 |
jihoonl
added a commit
that referenced
this pull request
Feb 11, 2016
Added repubServiceName parameter to TFClient.
k-aguete
pushed a commit
to k-aguete/roslibjs
that referenced
this pull request
Oct 21, 2022
* update built module * fix urls * mark version 0.18.0 * update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parameter is needed if your tf2_web_republisher is running in a namesspace.