Don't check in built content #643
Conversation
|
The only wat I accept such a change is, when we attach builds to the releases and/or release branches. |
| @@ -55,7 +55,7 @@ | |||
| "scripts": { | |||
| "build": "grunt build", | |||
| "doc": "grunt doc", | |||
| "test": "grunt test", | |||
| "test": "npm run build && grunt test", | |||
There was a problem hiding this comment.
Not accepting this change. When you make your case I could accept grunt build && grunt test
There was a problem hiding this comment.
npm run build here guarantees that if a user changes the build script, the changes are reflected here. Is your concern that it's NPM-specific? It seemed from the README that this project is developed with NPM.
Can you explain to me why the built content is checked into the repo? This is extremely atypical in my experience. The JavaScript ecosystem has package managers that work, we don't need to ship tarballs. |
MatthijsBurgh
added
the
v2
|
Superseded by #655 |
Public API Changes
None
Description
Removes the built content from the repository to avoid accidental creation of giant, hard-to-resolve diffs in PRs.
WIP/TODO: how to handle examples? should these require building? can we inject a browser require polyfill (if we're not already) to make the raw src work fine?