Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Service.advertise callback type #695

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Fix Service.advertise callback type #695

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/core/Service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,8 @@ export default class Service extends EventEmitter {
/**
* @callback advertiseCallback
* @param {TRequest} request - The service request.
* @param {Object} response - An empty dictionary. Take care not to overwrite this. Instead, only modify the values within.
* It should return true if the service has finished successfully,
* i.e., without any fatal errors.
* @param {Partial<TResponse>} response - An empty dictionary. Take care not to overwrite this. Instead, only modify the values within.
* @returns {boolean} true if the service has finished successfully, i.e., without any fatal errors.
*/
/**
* Advertise the service. This turns the Service object from a client
Expand Down