Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make universal pin labelling #5

Closed
6 tasks done
cewbdex opened this issue May 1, 2018 · 13 comments
Closed
6 tasks done

Make universal pin labelling #5

cewbdex opened this issue May 1, 2018 · 13 comments

Comments

@cewbdex
Copy link
Contributor

cewbdex commented May 1, 2018

Label ESP32 and AVR pins so they can be accessed universally (Eg. D1, A1).

@cewbdex cewbdex self-assigned this May 1, 2018
@cewbdex
Copy link
Contributor Author

cewbdex commented May 1, 2018

Ax are not possible to map on ESP32, because it already defines "ESP32 Dev Module".

@yaqwsx
Copy link
Member

yaqwsx commented May 1, 2018

What is the problem exactly?

@JarekParal
Copy link
Member

There is already #define A1 pinX probably. Is it true @CornyjK?

And what about create own board configuration for ALKS (for Arduino/PlatformIO)?

ESP32 ALKS ...

@cewbdex
Copy link
Contributor Author

cewbdex commented May 1, 2018

@JarekParal
Adding new board to boards.txt and making it's /variants/ file would work, it would also eliminate requirement of this library (at least pin definitions) for ESP32. Or you meant another way? Maybie they would accept pull request with our board variant.
EDIT:
Yes, it's already defined in /variants/ESP32/pins_arduino.h.
Switching to "Electronic SweetPeas - ESP320" would solve this issue, but it does not give ability to change certain things (eg. flash mode and flash size).

@JarekParal
Copy link
Member

It would be nice to have own board.txt (or pins_arduino.h) and send pull request to Arduino and PlatformIO.

@JarekParal
Copy link
Member

What we will do with this @CornyjK :-)?

Are the digital pins (D1, D2, ...) on ESP32 implemented?

@cewbdex
Copy link
Contributor Author

cewbdex commented Jun 11, 2018

@JarekParal
In this PR

@cewbdex cewbdex changed the title Make universal pin labeling Make universal pin labelling Jun 11, 2018
@JarekParal
Copy link
Member

Ok, could you send pull-request @CornyjK?

@cewbdex
Copy link
Contributor Author

cewbdex commented Jun 11, 2018

@JarekParal
I think it should be completed first (third point above, also second - send pull request to ESP32 library). In my opinion this should be in next release.

@JarekParal
Copy link
Member

JarekParal commented Jun 11, 2018

I agree with your answer @CornyjK. Could you define pins in this library for SPI, I2C on the ESP32 as I mentioned in the issue RoboticsBrno/ArduinoLearningKitStarter#21.

@cewbdex
Copy link
Contributor Author

cewbdex commented Jun 11, 2018

Here is preview of file for PR.

@cewbdex
Copy link
Contributor Author

cewbdex commented Jun 16, 2018

SPI/IIC has the same issue as the analog pins.

@JarekParal
Copy link
Member

JarekParal referenced this issue Jun 23, 2018
@cewbdex cewbdex moved this from Working on to Done in Development roadmap Jul 18, 2018
cewbdex added a commit that referenced this issue Jul 19, 2018
* Initial support

* Add SPI and I2C pins

* Add simplified functions

* Add support for ALKSESP32 board variant

* Revert "Add simplified functions"

This reverts commit 16aab29.

* Improvement

* Change #elif defined(ALKSESP32) description

* Move comment

* Add a notice
@cewbdex cewbdex closed this as completed Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants