Improve unit tests for Accessions and API #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaSistrunk
approved these changes
Jun 30, 2021
p-galligan
approved these changes
Jun 30, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding additional tests to cover functionality in Accession and API views and serializers. This also involved factoring out some smaller units of code from Accession views, which were really complicated and thus difficult to test.
Introduces fixtures and converts to TransactionTestCase (rather than TestCase) for more predictable database state.
Also debugs the setup of ClamAV - fetching definitions via
wgetis no longer supported, so we are now usingfreshclamFixes #456 fixes #457
Some tests have been commented out, but will be fixed as I work through the rest of the unit tests.