Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves display of rights statements #538

Merged
merged 7 commits into from
Jun 28, 2022
Merged

Improves display of rights statements #538

merged 7 commits into from
Jun 28, 2022

Conversation

helrond
Copy link
Member

@helrond helrond commented Jun 28, 2022

Moves rights box up on detail page, fixes #507
Encodes rights statements as ul, fixes #533

@helrond helrond requested a review from HaSistrunk June 28, 2022 13:15
@HaSistrunk
Copy link
Member

HaSistrunk commented Jun 28, 2022

Cool, #533 fix is simple and seems to work well. For #507 I see that the issue is:

It is not immediately clear to end users which records are embargoed and for how long.

I'm wondering about the "for how long" part, because some rights notes for orgs indicate numbers of years in the note, but others do not. Should this be a matter of standardizing the rights notes to contain the same info, or do we need to add the date rules to this transfer detail information?

@helrond
Copy link
Member Author

helrond commented Jun 28, 2022

Good catch @HaSistrunk - can you take a look at the most recent update and see how that works?

@HaSistrunk
Copy link
Member

HaSistrunk commented Jun 28, 2022

can you take a look at the most recent update and see how that works?

Yeah, that's great! I'm not sure the days of the week are necessary, e.g. Monday, Dec 31 2136 if that's easy to remove, but overall I think this is a nice addition.

@helrond helrond merged commit c16721a into base Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve record type display in rights statement table Provide better visibility for rights statements
2 participants