-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Quote feature in EmbeddedChat #172
Comments
Hey @sidmohanty11, I would like to work on this issue. Please assign it to me. Thanks! |
@sidmohanty11 Is this issue assigned to someone? I would like to work on this and submit the PR ASAP. |
Hey, @YashTote thanks a lot for showing interest in this feature. We are currently in the mid of a major refactoring spree and any feature addition is actually put on hold for a bit. But still, if you want to contribute feel free to take a pull from the develop branch, get in touch with @abhinavkrin regarding the development steps on https://open.rocket.chat and create a PR to that branch. Thanks! |
Hey @sidmohanty11 . Is this feature required? |
If required, I'm working on this one. |
Hey @umangutkarsh sorry for the late response! Go ahead! |
Hey @sidmohanty11 . No worries. I am currently working on this. This is the solution I've come up with and the approach I'm following:
The code is almost ready, just the rendering of the quotedMessages as an attachment is left. Please review this if I should work further on this. |
Hi @sidmohanty11 . Please let me know whenever you are available. |
Hi @sidmohanty11 @abhinavkrin . I've almost integrated the 'Quote-Message feature' for embeddedChat, except for some issues which I'm currently facing. Anything else should I consider? Please let me know quote.webm |
Hi @abhinavkrin @sidmohanty11 . Should I create a draft PR for this? So that it is easy to review the approach I have followed? Thanks. |
Sure @umangutkarsh you can create a draft pr. |
Hi @abhinavkrin . I've created a draft pr, please review it. Also about the 'Invalid time value' error, I'll look into it. Please let me know. Thank you. |
As an EmbeddedChat developer
I need to:
Add a Quote Functionality
So That:
users would be able to easily reference and respond to specific messages by simply selecting the quote option and selecting the message they want to reference. This would make conversations more organized and efficient, as users would no longer need to manually copy and paste previous messages in order to reference them.
Acceptance Criteria
The text was updated successfully, but these errors were encountered: