Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/draft quote message #422

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

umangutkarsh
Copy link
Contributor

@umangutkarsh umangutkarsh commented Jan 23, 2024

Brief Title

This PR is a draft PR to add the quote-message feature in EmbeddedChat.

Acceptance Criteria fulfillment

  • Design the user interface for the quote feature, including how users will select messages to quote and how the quoted messages will be displayed.
  • Develop the code for the quote feature, integrating it into the existing chat system.

Addresses #172

Video/Screenshots

quote-message.webm

Copy link
Collaborator

@sidmohanty11 sidmohanty11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@umangutkarsh seems to me this is not ready to review yet?

@umangutkarsh
Copy link
Contributor Author

umangutkarsh commented Feb 17, 2024

@umangutkarsh seems to me this is not ready to review yet?

Yup. I still have to work on this. Created a draft pr as per:- comment1 , comment2

Just wanted to confirm whether I should continue on this

scrollToBottom();
messageRef.current.style.height = '44px';
const message = messageRef.current.value.trim();
console.log(message);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
console.log(message);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sure. I will clean up the code in the final PR (whenever needed), I just wanted to confirm if I should work further on this, that is why I created this one.

@umangutkarsh
Copy link
Contributor Author

Hi @sidmohanty11 . should I continue to work on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants